diff --git a/SOPE/GDLContentStore/EOQualifier+GCS.m b/SOPE/GDLContentStore/EOQualifier+GCS.m index 88343350e..965ea77e6 100644 --- a/SOPE/GDLContentStore/EOQualifier+GCS.m +++ b/SOPE/GDLContentStore/EOQualifier+GCS.m @@ -96,6 +96,7 @@ else { [self errorWithFormat:@"%s: unsupported operation for null: %@", __PRETTY_FUNCTION__, NSStringFromSelector(op)]; + qOperator = @"="; } if ([val isKindOfClass:[NSNumber class]]) @@ -109,6 +110,7 @@ } } else { + isCI = NO; if (sel_eq(op, EOQualifierOperatorEqual)) { qOperator = @"IS"; qValue = @"NULL"; @@ -118,6 +120,8 @@ qValue = @"NULL"; } else { + qOperator = @"IS"; + qValue = @"NULL"; [self errorWithFormat:@"%s: invalid operation for null: %@", __PRETTY_FUNCTION__, NSStringFromSelector(op)]; } diff --git a/SOPE/GDLContentStore/GCSFolder.m b/SOPE/GDLContentStore/GCSFolder.m index 23cbbdec0..73b60ebda 100644 --- a/SOPE/GDLContentStore/GCSFolder.m +++ b/SOPE/GDLContentStore/GCSFolder.m @@ -757,7 +757,9 @@ static GCSStringFormatter *stringFormatter = nil; [self errorWithFormat:@"could not open storage channel!"]; return nil; } - if (!self->ofFlags.sameTableForQuick) { + if (!self->ofFlags.sameTableForQuick) + quickChannel = nil; + else { if ((quickChannel = [self acquireQuickChannel]) == nil) { [self errorWithFormat:@"could not open quick channel!"]; [self releaseChannel:storeChannel]; @@ -1103,25 +1105,25 @@ static GCSStringFormatter *stringFormatter = nil; [sql appendString:[self aclTableName]]; [sql appendString:@" WHERE "]; [sql appendString:[self generateSQLForQualifier:qualifier]]; - } - /* open channel */ + /* open channel */ - if ((channel = [self acquireAclChannel]) == nil) { - [self errorWithFormat:@"could not open acl channel!"]; - return; - } + if ((channel = [self acquireAclChannel]) == nil) { + [self errorWithFormat:@"could not open acl channel!"]; + return; + } - /* run SQL */ - - if ((error = [channel evaluateExpressionX:sql]) != nil) { - [self errorWithFormat:@"%s: cannot execute acl-fetch SQL '%@': %@", + /* run SQL */ + + if ((error = [channel evaluateExpressionX:sql]) != nil) { + [self errorWithFormat:@"%s: cannot execute acl-fetch SQL '%@': %@", __PRETTY_FUNCTION__, sql, error]; - [self releaseChannel:channel]; - return; - } + [self releaseChannel:channel]; + return; + } - [self releaseChannel:channel]; + [self releaseChannel:channel]; + } } /* description */ diff --git a/SOPE/NGCards/iCalDateTime.m b/SOPE/NGCards/iCalDateTime.m index 159545e81..fe88452e1 100644 --- a/SOPE/NGCards/iCalDateTime.m +++ b/SOPE/NGCards/iCalDateTime.m @@ -68,6 +68,9 @@ [calendar addTimeZone: iTZ]; newTZId = [iTZ tzId]; } + else + newTZId = nil; + [self setValue: 0 ofAttribute: @"tzid" to: newTZId]; [self setDateTime: dateTime]; } diff --git a/SoObjects/Mailer/SOGoMailBodyPart.h b/SoObjects/Mailer/SOGoMailBodyPart.h index 0effd14cf..4234074d0 100644 --- a/SoObjects/Mailer/SOGoMailBodyPart.h +++ b/SoObjects/Mailer/SOGoMailBodyPart.h @@ -59,7 +59,6 @@ - (id) partInfo; - (NSData *) fetchBLOB; - (void) setAsAttachment; -- (BOOL) asAttachment; /* factory */ diff --git a/UI/MailPartViewers/UIxMailPartICalViewer.m b/UI/MailPartViewers/UIxMailPartICalViewer.m index 3ee2c8f61..737e17d27 100644 --- a/UI/MailPartViewers/UIxMailPartICalViewer.m +++ b/UI/MailPartViewers/UIxMailPartICalViewer.m @@ -92,7 +92,7 @@ - (BOOL) couldParseCalendar { - return (([self inCalendar])); + return ([self inCalendar] != nil); } - (iCalEvent *) inEvent @@ -246,7 +246,7 @@ - (BOOL) isEventStoredInCalendar { - return (([self storedEventObject])); + return ([self storedEventObject] != nil); } - (iCalEvent *) storedEvent @@ -376,7 +376,7 @@ - (BOOL) isReplySenderAnAttendee { - return (([self storedReplyAttendee])); + return ([self storedReplyAttendee] != nil); } - (iCalPerson *) _emailParticipantWithEvent: (iCalEvent *) event diff --git a/UI/MailerUI/UIxMailMainFrame.m b/UI/MailerUI/UIxMailMainFrame.m index b0967759a..400e32802 100644 --- a/UI/MailerUI/UIxMailMainFrame.m +++ b/UI/MailerUI/UIxMailMainFrame.m @@ -20,8 +20,10 @@ */ #import + #import #import +#import #import #import diff --git a/UI/SOGoUI/SOGoACLAdvisory.h b/UI/SOGoUI/SOGoACLAdvisory.h index d991dbad0..7f200d813 100644 --- a/UI/SOGoUI/SOGoACLAdvisory.h +++ b/UI/SOGoUI/SOGoACLAdvisory.h @@ -59,6 +59,12 @@ @end +@interface SOGoACLModificationAdvisory : SOGoACLAdvisory + +- (NSString *) aclMethod; + +@end + @interface SOGoACLEnglishAdditionAdvisory : SOGoACLAdditionAdvisory @end @@ -68,13 +74,13 @@ @interface SOGoACLGermanAdditionAdvisory : SOGoACLAdditionAdvisory @end -@interface SOGoACLEnglishModificationAdvisory : SOGoACLAdditionAdvisory +@interface SOGoACLEnglishModificationAdvisory : SOGoACLModificationAdvisory @end -@interface SOGoACLFrenchModificationAdvisory : SOGoACLAdditionAdvisory +@interface SOGoACLFrenchModificationAdvisory : SOGoACLModificationAdvisory @end -@interface SOGoACLGermanModificationAdvisory : SOGoACLAdditionAdvisory +@interface SOGoACLGermanModificationAdvisory : SOGoACLModificationAdvisory @end @interface SOGoACLEnglishRemovalAdvisory : SOGoACLRemovalAdvisory diff --git a/UI/SOGoUI/SOGoACLAdvisory.m b/UI/SOGoUI/SOGoACLAdvisory.m index 97994ae3c..ffefbd0bc 100644 --- a/UI/SOGoUI/SOGoACLAdvisory.m +++ b/UI/SOGoUI/SOGoACLAdvisory.m @@ -20,6 +20,8 @@ * Boston, MA 02111-1307, USA. */ +#import + #import #import #import diff --git a/UI/Scheduler/UIxAppointmentEditor.m b/UI/Scheduler/UIxAppointmentEditor.m index cd5331e32..382ff96d1 100644 --- a/UI/Scheduler/UIxAppointmentEditor.m +++ b/UI/Scheduler/UIxAppointmentEditor.m @@ -24,6 +24,7 @@ #import #import +#import #import #import diff --git a/UI/Scheduler/UIxCalListingActions.m b/UI/Scheduler/UIxCalListingActions.m index e41f23e0a..a44c818f8 100644 --- a/UI/Scheduler/UIxCalListingActions.m +++ b/UI/Scheduler/UIxCalListingActions.m @@ -344,7 +344,8 @@ [newEvent addObject: [self _formattedDateForSeconds: interval forAllDay: isAllDay]]; - participants = state = nil; + participants = nil; + state = nil; if ([[oldEvent objectAtIndex: 9] length] > 0 && [[oldEvent objectAtIndex: 10] length] > 0) { participants = [[oldEvent objectAtIndex: 9] componentsSeparatedByString: @"\n"]; @@ -389,7 +390,7 @@ ascending = [[context request] formValueForKey: @"asc"]; if (![ascending boolValue]) - newEvents = [newEvents reversedArray]; + [newEvents reverseArray]; return [self _responseWithData: newEvents]; } diff --git a/UI/Scheduler/UIxCalView.m b/UI/Scheduler/UIxCalView.m index 62fb66fe1..f48cb1639 100644 --- a/UI/Scheduler/UIxCalView.m +++ b/UI/Scheduler/UIxCalView.m @@ -1,8 +1,30 @@ +/* UIxCalMainView.m - this file is part of SOGo + * + * Copyright (C) 2006, 2007 Inverse groupe conseil + * + * Author: Wolfgang Sourdeau + * + * This file is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2, or (at your option) + * any later version. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; see the file COPYING. If not, write to + * the Free Software Foundation, Inc., 59 Temple Place - Suite 330, + * Boston, MA 02111-1307, USA. + */ //#import #import #import +#import #import #import #import diff --git a/UI/Scheduler/UIxTaskEditor.m b/UI/Scheduler/UIxTaskEditor.m index 7ec0b0d40..295bbcc75 100644 --- a/UI/Scheduler/UIxTaskEditor.m +++ b/UI/Scheduler/UIxTaskEditor.m @@ -22,6 +22,7 @@ #import #import +#import #import #import