Monotone-Parent: 2da3fdffb894897d29ea164dddd960be3c7f92bf

Monotone-Revision: 90a515f4d4cb5b17faf03e3b53acdc1a2f70a21a

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2009-02-06T20:15:41
Monotone-Branch: ca.inverse.sogo

ChangeLog

@@ -1,5 +1,17 @@
 2009-02-06  Wolfgang Sourdeau  <wsourdeau@inverse.ca>
 
+	* UI/Scheduler/UIxTaskEditor.m ([UIxTaskEditor -dealloc])
+	([UIxTaskEditor -todo]): same as below (apts).
+
+	* UI/Scheduler/UIxAppointmentEditor.m ([UIxAppointmentEditor
+	-event]): retain the event parent calendar object instead of the
+	event itself.
+	([UIxAppointmentEditor -dealloc]): release the above calendar.
+
+	* UI/MailPartViewers/UIxMailPartICalViewer.m
+	([UIxMailPartICalViewer -dealloc]): no longer release "inEvent"
+	since it does not need to be retained.
+
 	* Main/SOGo.m ([SOGo +initialize]): added handling of the
 	"SOGoDebugLeaks" configuration variable.
 	([SOGo -dispatchRequest:_request]): log the classes of instances

SOPE/NGCards/CardElement.m

@@ -105,7 +105,6 @@
 
 - (void) dealloc
 {
-  [parent release];
   [tag release];
   [group release];
   [attributes release];
@@ -115,8 +114,7 @@
 
 - (void) setParent: (CardGroup *) aParent
 {
-#warning THIS CAUSES A LEAK. We need this for the moment because of a design error.
-  ASSIGN (parent, aParent);
+  parent = aParent;
 }
 
 - (id) parent

UI/MailPartViewers/UIxMailPartICalViewer.m

@@ -57,7 +57,6 @@
   [attendee release];
   [item release];
   [inCalendar release];
-  [inEvent release];
   [dateFormatter release];
   [super dealloc];
 }
@@ -67,7 +66,7 @@
 - (void) resetPathCaches
 {
   [super resetPathCaches];
-  [inEvent release]; inEvent = nil;
+  inEvent = nil;
   [inCalendar release]; inCalendar = nil;
   [storedEventObject release]; storedEventObject = nil;
   [storedEvent release]; storedEvent = nil;
@@ -104,7 +103,7 @@
     {
       events = [[self inCalendar] events];
       if ([events count] > 0)
-	inEvent = [[events objectAtIndex: 0] retain];
+	inEvent = [events objectAtIndex: 0];
     }
 
   return inEvent;

UI/Scheduler/UIxAppointmentEditor.m

@@ -74,7 +74,7 @@
 - (void) dealloc
 {
   [item release];
-  [event release];
+  [[event parent] release];
   [aptStartDate release];
   [aptEndDate release];
   [componentCalendar release];
@@ -87,7 +87,7 @@
   if (!event)
     {
       event = (iCalEvent *) [[self clientObject] occurence];
-      [event retain];
+      [[event parent] retain];
     }
 
   return event;

UI/Scheduler/UIxTaskEditor.m

@@ -67,7 +67,7 @@
   [statusDate release];
   [status release];
   [statusPercent release];
-  [todo release];
+  [[todo parent] release];
   [super dealloc];
 }
 
@@ -77,7 +77,7 @@
   if (!todo)
     {
       todo = (iCalToDo *) [[self clientObject] component: YES secure: YES];
-      [todo retain];
+      [[todo parent] retain];
     }
 
   return todo;