From 1c99c2ca42d07ae126091620bfca45acbfea5c64 Mon Sep 17 00:00:00 2001
From: Francis Lachapelle <flachapelle@inverse.ca>
Date: Fri, 24 Jul 2020 15:47:17 -0400
Subject: [PATCH] fix(web): consistency in icon of expandable list items

See https://material.io/components/lists#types
---
 UI/Templates/PreferencesUI/UIxAccountEditor.wox                 | 2 +-
 UI/Templates/UIxAclEditor.wox                                   | 2 +-
 UI/WebServerResources/js/Preferences/AccountDialogController.js | 2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/UI/Templates/PreferencesUI/UIxAccountEditor.wox b/UI/Templates/PreferencesUI/UIxAccountEditor.wox
index 37a5dd6ba..eddfac80d 100644
--- a/UI/Templates/PreferencesUI/UIxAccountEditor.wox
+++ b/UI/Templates/PreferencesUI/UIxAccountEditor.wox
@@ -131,7 +131,7 @@
                                ng-click="$AccountDialogController.setDefaultIdentity($event, $index)">
                       <md-icon ng-class="{ 'md-warn md-hue-2': identity.isDefault }">{{ identity.isDefault ? 'favorite' : 'favorite_border' }}</md-icon>
                     </md-button>
-                    <md-icon ng-class="{ 'md-rotate-90': $index == $AccountDialogController.selectedIdentity }">chevron_right</md-icon>
+                    <md-icon ng-class="{ 'md-rotate-180': $index == $AccountDialogController.selectedIdentity }">expand_more</md-icon>
                   </div>
                 </a>
                 <md-card-content ng-show="$index == $AccountDialogController.selectedIdentity">
diff --git a/UI/Templates/UIxAclEditor.wox b/UI/Templates/UIxAclEditor.wox
index d49828ae4..b0d21a416 100644
--- a/UI/Templates/UIxAclEditor.wox
+++ b/UI/Templates/UIxAclEditor.wox
@@ -75,7 +75,7 @@
                        ng-hide="user.uid != acl.selectedUid || user.$isSpecial()">
               <md-icon>delete</md-icon>
             </md-button>
-            <md-icon ng-class="{ 'md-rotate-90': acl.showRights(user) }">chevron_right</md-icon>
+            <md-icon ng-class="{ 'md-rotate-180': acl.showRights(user) }">expand_more</md-icon>
           </div>
         </a>
         <md-card-content id="AccessRightList" ng-show="acl.showRights(user)">
diff --git a/UI/WebServerResources/js/Preferences/AccountDialogController.js b/UI/WebServerResources/js/Preferences/AccountDialogController.js
index a5df047c1..661f86612 100644
--- a/UI/WebServerResources/js/Preferences/AccountDialogController.js
+++ b/UI/WebServerResources/js/Preferences/AccountDialogController.js
@@ -98,6 +98,8 @@
       var firstReadonlyIndex = _.findIndex(this.account.identities, { isReadOnly: 1 });
       var identity = {};
 
+      if (firstReadonlyIndex < 0)
+        firstReadonlyIndex = this.account.identities.length;
       if (this.customFromIsReadonly())
         identity.fullName = this.account.identities[0].fullName;
       this.account.identities.splice(Math.max(firstReadonlyIndex, 0), 0, identity);