From 30a81528a2e251a4735f4f9d84b53c0c01347fdd Mon Sep 17 00:00:00 2001
From: Francis Lachapelle <flachapelle@inverse.ca>
Date: Thu, 2 Aug 2018 09:29:33 -0400
Subject: [PATCH] (js) Prohibit duplicate calendar categories

---
 NEWS                                          |  1 +
 .../English.lproj/Localizable.strings         |  2 ++
 UI/Templates/PreferencesUI/UIxPreferences.wox |  7 ++++++-
 .../js/Preferences/PreferencesController.js   | 19 +++++++++++++++++++
 4 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index e3c08055b..17eeb8fbb 100644
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ New features
  - [web] move mailboxes (#644, #3511, #4479)
 
 Enhancements
+ - [web] prohibit duplicate calendar categories in Preferences module
  - [web] added Romanian (ro) translation - thanks to Vasile Razvan Luca
 
 Bug fixes
diff --git a/UI/PreferencesUI/English.lproj/Localizable.strings b/UI/PreferencesUI/English.lproj/Localizable.strings
index ac5a4444a..68d2a7004 100644
--- a/UI/PreferencesUI/English.lproj/Localizable.strings
+++ b/UI/PreferencesUI/English.lproj/Localizable.strings
@@ -124,6 +124,8 @@
 "Prevent from being invited to appointments" = "Prevent from being invited to appointments";
 "White list for appointment invitations" = "White list for appointment invitations";
 "Contacts Names" = "Contacts Names";
+"Duplicate name" = "Duplicate name";
+"Calendar categories must have unique names." = "Calendar categories must have unique names.";
 
 /* Default Calendar */
 "Default calendar" = "Default calendar";
diff --git a/UI/Templates/PreferencesUI/UIxPreferences.wox b/UI/Templates/PreferencesUI/UIxPreferences.wox
index 7c3e039ad..45afb9c93 100644
--- a/UI/Templates/PreferencesUI/UIxPreferences.wox
+++ b/UI/Templates/PreferencesUI/UIxPreferences.wox
@@ -410,9 +410,14 @@
                                          track by $index">
                   <sg-color-picker ng-model="app.preferences.defaults.SOGoCalendarCategoriesColors[item]"><!-- color picker--></sg-color-picker>
                   <md-input-container class="md-block md-flex">
-	            <input type="text" label:aria-label="Calendar Category"
+	            <input type="text" label:aria-label="Calendar Category" required="required"
+                           name="calendarCategory_{{$index}}"
                            ng-model="app.preferences.defaults.SOGoCalendarCategories[$index]"
+                           ng-change="app.resetCalendarCategoryValidity($index, preferencesForm)"
                            sg-focus-on="calendarCategory_{{$index}}"/>
+                    <div ng-messages="preferencesForm['calendarCategory_' + $index].$error">
+                      <div ng-message="duplicate"><var:string label:value="Duplicate name"/></div>
+                    </div>
                   </md-input-container>
                   <md-button class="sg-icon-button" type="button"
                              layout="row" layout-align="end center"
diff --git a/UI/WebServerResources/js/Preferences/PreferencesController.js b/UI/WebServerResources/js/Preferences/PreferencesController.js
index 3dc12a291..b92f9cc0d 100644
--- a/UI/WebServerResources/js/Preferences/PreferencesController.js
+++ b/UI/WebServerResources/js/Preferences/PreferencesController.js
@@ -69,6 +69,10 @@
       form.$setDirty();
     };
 
+    this.resetCalendarCategoryValidity = function(index, form) {
+      form['calendarCategory_' + index].$setValidity('duplicate', true);
+    };
+
     this.removeCalendarCategory = function(index, form) {
       var key = this.preferences.defaults.SOGoCalendarCategories[index];
       this.preferences.defaults.SOGoCalendarCategories.splice(index, 1);
@@ -320,6 +324,7 @@
         }
       }
 
+      // IMAP labels must be unique
       if (this.preferences.defaults.SOGoMailLabelsColorsKeys.length !=
           this.preferences.defaults.SOGoMailLabelsColorsValues.length ||
           this.preferences.defaults.SOGoMailLabelsColorsKeys.length !=
@@ -335,6 +340,20 @@
         });
       }
 
+      // Calendar categories must be unique
+      if (this.preferences.defaults.SOGoCalendarCategories.length !=
+          _.uniq(this.preferences.defaults.SOGoCalendarCategories).length) {
+        Dialog.alert(l('Error'), l("Calendar categories must have unique names."));
+        _.forEach(this.preferences.defaults.SOGoCalendarCategories, function (value, i, keys) {
+          if (form['calendarCategory_' + i].$dirty &&
+              (keys.indexOf(value) != i ||
+               keys.indexOf(value, i+1) > -1)) {
+            form['calendarCategory_' + i].$setValidity('duplicate', false);
+            sendForm = false;
+          }
+        });
+      }
+
       if (sendForm)
         return this.preferences.$save().then(function(data) {
           if (!options || !options.quick) {