Monotone-Parent: c3b32ea543ff55ff243677d396e4119c69bc0fbc

Monotone-Revision: 137c790e1a56597f25936f21d69eb6a067d1dc8d

Monotone-Author: wsourdeau@inverse.ca
Monotone-Date: 2011-04-19T22:26:47
Monotone-Branch: ca.inverse.sogo

ChangeLog

@@ -1,5 +1,10 @@
 2011-04-19  Wolfgang Sourdeau  <wsourdeau@inverse.ca>
 
+	* OpenChange/MAPIStoreMessage.m (-attachmentTable): as all the
+	subclasses were using the same MAPIStoreAttachmentTable
+	implementation, this method now performs the same operation and
+	thereby no longer requires subclasssing.
+
 	* OpenChange/MAPIStoreObject.m (-getProperty:withTag:): compute
 	the method selector and pass it as argument to the IMP of the
 	property getter, as would be with any regular method invocation.

OpenChange/MAPIStoreCalendarMessage.m

@@ -40,7 +40,6 @@
 #import <SOGo/SOGoUserDefaults.h>
 #import <Appointments/SOGoAppointmentObject.h>
 
-#import "MAPIStoreAttachmentTable.h"
 #import "MAPIStoreCalendarAttachment.h"
 #import "MAPIStoreContext.h"
 #import "MAPIStoreRecurrenceUtils.h"
@@ -566,11 +565,6 @@ _fillAppointmentRecurrencePattern (struct AppointmentRecurrencePattern *arp,
   return [attachmentParts objectForKey: childKey];
 }
 
-- (MAPIStoreAttachmentTable *) attachmentTable
-{
-  return [MAPIStoreAttachmentTable tableForContainer: self];
-}
-
 - (MAPIStoreAttachment *) createAttachment
 {
   MAPIStoreCalendarAttachment *newAttachment;

OpenChange/MAPIStoreDraftsMessage.m

@@ -29,7 +29,6 @@
 #import <Mailer/SOGoDraftObject.h>
 #import <NGObjWeb/WOContext+SoObjects.h>
 
-#import "MAPIStoreAttachmentTable.h"
 #import "MAPIStoreContext.h"
 #import "MAPIStoreDraftsAttachment.h"
 #import "MAPIStoreTypes.h"
@@ -165,11 +164,6 @@ e)
     [self _saveAttachment: [attachmentKeys objectAtIndex: count]];
 }
 
-- (MAPIStoreAttachmentTable *) attachmentTable
-{
-  return [MAPIStoreAttachmentTable tableForContainer: self];
-}
-
 - (MAPIStoreAttachment *) createAttachment
 {
   MAPIStoreDraftsAttachment *newAttachment;

OpenChange/MAPIStoreMailMessage.m

@@ -86,11 +86,6 @@ static Class NSExceptionK, MAPIStoreSentItemsFolderK, MAPIStoreDraftsFolderK;
   MAPIStoreDraftsFolderK = [MAPIStoreDraftsFolder class];
 }
 
-- (MAPIStoreAttachmentTable *) attachmentTable
-{
-  return [MAPIStoreAttachmentTable tableForContainer: self];
-}
-
 - (int) getPrIconIndex: (void **) data
 {
   uint32_t longValue;

OpenChange/MAPIStoreMessage.m

@@ -26,6 +26,7 @@
 #import <NGExtensions/NSObject+Logs.h>
 #import <SOGo/SOGoObject.h>
 
+#import "MAPIStoreAttachmentTable.h"
 #import "MAPIStoreContext.h"
 #import "MAPIStoreTypes.h"
 #import "NSData+MAPIStore.h"
@@ -301,7 +302,7 @@
       stringValue = [NSString stringWithFormat: @"SOGo%@%@%@",
                               stringValue, stringValue, stringValue];
       *data = [[stringValue dataUsingEncoding: NSASCIIStringEncoding]
-                asShortBinaryInMemCtx: memCtx];
+                asBinaryInMemCtx: memCtx];
     }
   else
     rc = MAPISTORE_ERR_NOT_FOUND;
@@ -416,9 +417,7 @@
 
 - (MAPIStoreAttachmentTable *) attachmentTable
 {
-  [self subclassResponsibility: _cmd];
-
-  return nil;
+  return [MAPIStoreAttachmentTable tableForContainer: self];
 }
 
 - (void) addActiveTable: (MAPIStoreTable *) activeTable