From 806ea9fd13a307bf71762da938a49db0b1acd33f Mon Sep 17 00:00:00 2001 From: Wolfgang Sourdeau Date: Tue, 30 Oct 2012 08:49:51 -0400 Subject: [PATCH] do not duplicate the result of method calls into a NSMutableString --- SOPE/GDLContentStore/GCSFolder.m | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/SOPE/GDLContentStore/GCSFolder.m b/SOPE/GDLContentStore/GCSFolder.m index ec9c0283a..af49f91ce 100644 --- a/SOPE/GDLContentStore/GCSFolder.m +++ b/SOPE/GDLContentStore/GCSFolder.m @@ -351,15 +351,12 @@ static GCSStringFormatter *stringFormatter = nil; - (NSString *) _selectedFields: (NSArray *) fields requirement: (GCSTableRequirement) requirement { - NSMutableString *selectedFields; - - selectedFields = [NSMutableString string]; + NSString *selectedFields; - if (requirement == bothTableRequired - && [fields containsObject: @"c_name"]) - [selectedFields appendString: [self _dottedFields: fields]]; + if (requirement == bothTableRequired && [fields containsObject: @"c_name"]) + selectedFields = [self _dottedFields: fields]; else - [selectedFields appendString: [fields componentsJoinedByString: @", "]]; + selectedFields = [fields componentsJoinedByString: @", "]; return selectedFields; }