test helpers: avoid unnecessary copies

Change-Id: I014cedcc10078ce03d1f4f3ae9403b6282b7dcac

loolwsd/.clang-tidy

@@ -0,0 +1,3 @@
+Checks: 'clang-diagnostic-*,performance-*,unused-*,misc-*,readability-redundant-*'
+WarningsAsErrors: '*'
+

loolwsd/.gitignore

@@ -36,7 +36,6 @@ test/data/hello-world.odt
 *.o
 *.exe
 cscope*
-.*
 *.orig
 
 connect

loolwsd/test/helpers.hpp

@@ -311,7 +311,7 @@ std::vector<char> getResponseMessage(Poco::Net::WebSocket& ws, const std::string
 }
 
 inline
-std::vector<char> getResponseMessage(const std::shared_ptr<Poco::Net::WebSocket>& ws, const std::string& prefix, const std::string name = "")
+std::vector<char> getResponseMessage(const std::shared_ptr<Poco::Net::WebSocket>& ws, const std::string& prefix, const std::string& name = "")
 {
     return getResponseMessage(*ws, prefix, name);
 }
@@ -342,7 +342,7 @@ void getResponseMessage(const std::shared_ptr<Poco::Net::WebSocket>& ws, const s
 // connectLOKit ensures the websocket is connected to a kit process.
 inline
 std::shared_ptr<Poco::Net::WebSocket>
-connectLOKit(Poco::URI uri,
+connectLOKit(const Poco::URI& uri,
              Poco::Net::HTTPRequest& request,
              Poco::Net::HTTPResponse& response,
              const std::string& name = "")
@@ -409,7 +409,7 @@ std::shared_ptr<Poco::Net::WebSocket> loadDocAndGetSocket(const std::string& doc
 inline
 void SocketProcessor(const std::string& name,
                      const std::shared_ptr<Poco::Net::WebSocket>& socket,
-                     std::function<bool(const std::string& msg)> handler,
+                     const std::function<bool(const std::string& msg)>& handler,
                      const size_t timeoutMs = 10000)
 {
     socket->setReceiveTimeout(0);