haraldwolff
/
collabora-online
mirror of https://github.com/CollaboraOnline/online.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bgsave: unit test for a Kit crash during save disabling bgsave. 

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I8702776b73b5af8bb87aafe3551800d268b9f9c4
pull/9100/head
Michael Meeks 2024-05-18 19:55:45 +01:00
parent 91863875a7
commit 27bf41909e
1 changed files with 76 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

77
test/UnitSaveTorture.cpp
View File

@ -35,6 +35,7 @@ class UnitSaveTorture : public UnitWSD
void testModified();
void testTileCombineRace();
void testBgSaveCrash();
void testSaveTorture();
void configure(Poco::Util::LayeredConfiguration& config) override
@ -205,6 +206,7 @@ void UnitSaveTorture::testTileCombineRace()
{
std::chrono::seconds timeout = std::chrono::seconds(10);
auto message = wsSession->waitForMessage("unocommandresult:", timeout, name);
LOK_ASSERT(message.size() > 0);
bool success;
if (getSaveResult(message, success))
{
@ -216,6 +218,70 @@ void UnitSaveTorture::testTileCombineRace()
poll->joinThread();
}
void UnitSaveTorture::testBgSaveCrash()
{
std::string name = "testBgSaveCrash";
std::string docName = "empty.ods";
std::chrono::seconds timeout = std::chrono::seconds(10);
std::string documentPath, documentURL;
helpers::getDocumentPathAndURL(docName, documentPath, documentURL, name);
TST_LOG("Starting test on " << documentURL << ' ' << documentPath);
std::shared_ptr<SocketPoll> poll = std::make_shared<SocketPoll>("WebSocketPoll");
poll->startThread();
Poco::URI uri(helpers::getTestServerURI());
auto wsSession = helpers::loadDocAndGetSession(poll, docName, uri, testname);
TST_LOG("modify document");
modifyDocument(wsSession);
LOK_ASSERT_EQUAL(waitForModifiedStatus(name, wsSession, timeout), true);
createStamp("crashkitonsave");
forceAutosave = true;
// force a crashing save ...
wsSession->sendMessage(std::string("save dontTerminateEdit=0 dontSaveIfUnmodified=0"));
std::vector<char> message;
while (true)
{
message = wsSession->waitForMessage("unocommandresult:", timeout, name);
LOK_ASSERT(message.size() > 0);
bool success;
if (getSaveResult(message, success))
{
LOK_ASSERT_EQUAL(success, false); // bg save should crash and burn
break;
}
}
TST_LOG("Background save exited early as expected");
// Leave the crashing stamp - we should learn and save non-background now
wsSession->sendMessage(std::string("save dontTerminateEdit=0 dontSaveIfUnmodified=0"));
while (true)
{
message = wsSession->waitForMessage("unocommandresult:", timeout, name);
LOK_ASSERT(message.size() > 0);
bool success;
if (getSaveResult(message, success))
{
// non-bg save has no crash hook & should be fine.
LOK_ASSERT_EQUAL(success, true);
break;
}
}
TST_LOG("(non)-background save succeeded on 2nd attempt");
poll->joinThread();
}
namespace {
/*
* A sleep in a unit test !? but ... SfxBinding notifies its
@ -303,6 +369,7 @@ void UnitSaveTorture::saveTortureOne(
while (true)
{
message = wsSession->waitForMessage("unocommandresult:", timeout, name);
LOK_ASSERT(message.size() > 0);
bool success;
if (getSaveResult(message, success))
{
@ -355,6 +422,8 @@ void UnitSaveTorture::invokeWSDTest()
{
testModified();
testBgSaveCrash();
testTileCombineRace();
testSaveTorture();
@ -404,7 +473,13 @@ public:
virtual void postBackgroundSaveFork() override
{
std::cerr << "\n\npost background save process fork\n\n\n";
if (stampExists("crashkitonsave"))
{
std::cerr << "Exit bgsave process to simulate crash\n\n";
_exit(0); // otherwise we create segv's to count.
}
std::cerr << "\npost background save process fork\n\n";
waitWhileStamp("holdsave");
}