haraldwolff
/
collabora-online
mirror of https://github.com/CollaboraOnline/online.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

annotation: prevent page up/down button from messing the view 

problem:
when pressed page up/down button inside the annotation textarea,
entire view is forcefully pushed upwards to put the cursor at the top of view.
This is a chrome bug reported at: https://issues.chromium.org/issues/41417806

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I30048374e7b8330cd8c865010e3b4237d355391e
pull/7857/head
Pranam Lashkari 2024-03-01 23:24:15 +05:30 committed by Szymon Kłos
parent f00486ac52
commit 971b235514
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
browser/src/layer/tile/CommentSection.ts
View File

@ -865,8 +865,20 @@ export class Comment extends CanvasSectionObject {
if ((<any>window).mode.isDesktop()) {
if (e.keyCode === 27) {
this.onCancelClick(e);
} else if (e.keyCode === 33 /*PageUp*/ || e.keyCode === 34 /*PageDown*/) {
// work around for a chrome issue https://issues.chromium.org/issues/41417806
L.DomEvent.preventDefault(e);
var pos = e.keyCode === 33 ? 0 : e.target.textLength;
var currentPos = e.target.selectionStart;
if (e.shiftKey) {
var [start, end] = currentPos <= pos ? [currentPos, pos] : [pos, currentPos];
e.target.setSelectionRange(start, end, currentPos > pos ? 'backward' : 'forward');
} else {
e.target.setSelectionRange(pos, pos);
}
}
}
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types