2010-10-13 20:38:07 +02:00
|
|
|
|
2007-10-29 00:42:18 +01:00
|
|
|
/*
|
2009-01-08 00:38:59 +01:00
|
|
|
* QEMU OldWorld PowerMac (currently ~G3 Beige) hardware System Emulator
|
2007-10-29 00:42:18 +01:00
|
|
|
*
|
|
|
|
* Copyright (c) 2004-2007 Fabrice Bellard
|
|
|
|
* Copyright (c) 2007 Jocelyn Mayer
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
2019-05-23 16:35:08 +02:00
|
|
|
|
2016-01-26 19:16:58 +01:00
|
|
|
#include "qemu/osdep.h"
|
2019-05-23 16:35:08 +02:00
|
|
|
#include "qemu-common.h"
|
2018-06-25 14:42:24 +02:00
|
|
|
#include "qemu/units.h"
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
[Fix compilation without the spice devel packages. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-03-14 09:01:28 +01:00
|
|
|
#include "qapi/error.h"
|
2013-02-05 17:06:20 +01:00
|
|
|
#include "hw/ppc/ppc.h"
|
2019-08-12 07:23:51 +02:00
|
|
|
#include "hw/qdev-properties.h"
|
2013-01-24 00:03:54 +01:00
|
|
|
#include "mac.h"
|
2013-02-05 17:06:20 +01:00
|
|
|
#include "hw/input/adb.h"
|
2012-12-17 18:20:04 +01:00
|
|
|
#include "sysemu/sysemu.h"
|
2012-10-24 08:43:34 +02:00
|
|
|
#include "net/net.h"
|
2013-02-05 17:06:20 +01:00
|
|
|
#include "hw/isa/isa.h"
|
2013-01-24 00:03:54 +01:00
|
|
|
#include "hw/pci/pci.h"
|
2018-03-06 23:01:56 +01:00
|
|
|
#include "hw/pci/pci_host.h"
|
2013-01-24 00:03:54 +01:00
|
|
|
#include "hw/boards.h"
|
2013-02-05 17:06:20 +01:00
|
|
|
#include "hw/nvram/fw_cfg.h"
|
|
|
|
#include "hw/char/escc.h"
|
2018-02-28 21:32:37 +01:00
|
|
|
#include "hw/misc/macio/macio.h"
|
2013-01-24 00:03:54 +01:00
|
|
|
#include "hw/loader.h"
|
2018-08-29 18:59:09 +02:00
|
|
|
#include "hw/fw-path-provider.h"
|
2009-09-20 16:58:02 +02:00
|
|
|
#include "elf.h"
|
2015-12-17 17:35:09 +01:00
|
|
|
#include "qemu/error-report.h"
|
2012-12-17 18:20:04 +01:00
|
|
|
#include "sysemu/kvm.h"
|
2019-08-12 07:23:38 +02:00
|
|
|
#include "sysemu/reset.h"
|
2010-02-09 17:37:05 +01:00
|
|
|
#include "kvm_ppc.h"
|
2012-12-17 18:19:49 +01:00
|
|
|
#include "exec/address-spaces.h"
|
2007-10-29 00:42:18 +01:00
|
|
|
|
2007-12-02 05:51:10 +01:00
|
|
|
#define MAX_IDE_BUS 2
|
2008-12-24 21:29:16 +01:00
|
|
|
#define CFG_ADDR 0xf0000510
|
2013-06-29 17:34:58 +02:00
|
|
|
#define TBFREQ 16600000UL
|
2014-04-17 19:04:44 +02:00
|
|
|
#define CLOCKFREQ 266000000UL
|
|
|
|
#define BUSFREQ 66000000UL
|
2008-12-24 21:29:16 +01:00
|
|
|
|
2017-05-01 15:43:32 +02:00
|
|
|
#define NDRV_VGA_FILENAME "qemu_vga.ndrv"
|
|
|
|
|
2018-03-06 23:01:56 +01:00
|
|
|
#define GRACKLE_BASE 0xfec00000
|
2020-10-17 17:47:29 +02:00
|
|
|
#define PROM_BASE 0xffc00000
|
|
|
|
#define PROM_SIZE (4 * MiB)
|
2018-03-06 23:01:56 +01:00
|
|
|
|
2014-12-03 20:04:02 +01:00
|
|
|
static void fw_cfg_boot_set(void *opaque, const char *boot_device,
|
|
|
|
Error **errp)
|
2009-03-08 10:51:29 +01:00
|
|
|
{
|
2015-06-08 20:10:45 +02:00
|
|
|
fw_cfg_modify_i16(opaque, FW_CFG_BOOT_DEVICE, boot_device[0]);
|
2009-03-08 10:51:29 +01:00
|
|
|
}
|
|
|
|
|
2010-03-14 21:20:59 +01:00
|
|
|
static uint64_t translate_kernel_address(void *opaque, uint64_t addr)
|
|
|
|
{
|
|
|
|
return (addr & 0x0fffffff) + KERNEL_LOAD_ADDR;
|
|
|
|
}
|
|
|
|
|
2012-02-08 03:03:33 +01:00
|
|
|
static void ppc_heathrow_reset(void *opaque)
|
|
|
|
{
|
2012-05-04 17:42:23 +02:00
|
|
|
PowerPCCPU *cpu = opaque;
|
2012-02-08 03:03:33 +01:00
|
|
|
|
2012-05-04 17:42:23 +02:00
|
|
|
cpu_reset(CPU(cpu));
|
2012-02-08 03:03:33 +01:00
|
|
|
}
|
|
|
|
|
2014-05-07 16:42:57 +02:00
|
|
|
static void ppc_heathrow_init(MachineState *machine)
|
2007-10-29 00:42:18 +01:00
|
|
|
{
|
2014-05-07 16:42:57 +02:00
|
|
|
ram_addr_t ram_size = machine->ram_size;
|
|
|
|
const char *boot_device = machine->boot_order;
|
2012-05-04 17:38:41 +02:00
|
|
|
PowerPCCPU *cpu = NULL;
|
2012-03-14 01:38:23 +01:00
|
|
|
CPUPPCState *env = NULL;
|
2009-05-30 01:52:44 +02:00
|
|
|
char *filename;
|
2020-10-16 01:47:17 +02:00
|
|
|
int i;
|
2011-09-25 15:27:52 +02:00
|
|
|
MemoryRegion *bios = g_new(MemoryRegion, 1);
|
2011-06-15 23:27:19 +02:00
|
|
|
uint32_t kernel_base, initrd_base, cmdline_base = 0;
|
2009-01-24 13:00:23 +01:00
|
|
|
int32_t kernel_size, initrd_size;
|
2007-10-29 00:42:18 +01:00
|
|
|
PCIBus *pci_bus;
|
2020-06-10 07:32:03 +02:00
|
|
|
PCIDevice *macio;
|
2013-01-24 00:04:01 +01:00
|
|
|
MACIOIDEState *macio_ide;
|
2020-10-13 13:49:20 +02:00
|
|
|
ESCCState *escc;
|
2018-03-06 23:01:56 +01:00
|
|
|
SysBusDevice *s;
|
2018-02-28 21:32:36 +01:00
|
|
|
DeviceState *dev, *pic_dev;
|
2013-01-24 00:04:05 +01:00
|
|
|
BusState *adb_bus;
|
2020-10-17 17:47:29 +02:00
|
|
|
uint64_t bios_addr;
|
2018-12-14 14:30:50 +01:00
|
|
|
int bios_size;
|
2019-05-18 22:54:22 +02:00
|
|
|
unsigned int smp_cpus = machine->smp.cpus;
|
2009-03-08 10:51:29 +01:00
|
|
|
uint16_t ppc_boot_device;
|
2009-08-28 15:47:03 +02:00
|
|
|
DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS];
|
2008-12-24 21:29:16 +01:00
|
|
|
void *fw_cfg;
|
2014-07-13 22:29:02 +02:00
|
|
|
uint64_t tbfreq;
|
2007-10-29 00:42:18 +01:00
|
|
|
|
|
|
|
/* init CPUs */
|
|
|
|
for (i = 0; i < smp_cpus; i++) {
|
2017-10-09 21:50:53 +02:00
|
|
|
cpu = POWERPC_CPU(cpu_create(machine->cpu_type));
|
2012-05-04 17:38:41 +02:00
|
|
|
env = &cpu->env;
|
|
|
|
|
2009-01-14 15:48:04 +01:00
|
|
|
/* Set time-base frequency to 16.6 Mhz */
|
2013-06-29 17:34:58 +02:00
|
|
|
cpu_ppc_tb_init(env, TBFREQ);
|
2012-05-04 17:42:23 +02:00
|
|
|
qemu_register_reset(ppc_heathrow_reset, cpu);
|
2007-10-29 00:42:18 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/* allocate RAM */
|
2018-06-25 14:42:24 +02:00
|
|
|
if (ram_size > 2047 * MiB) {
|
|
|
|
error_report("Too much memory for this machine: %" PRId64 " MB, "
|
|
|
|
"maximum 2047 MB", ram_size / MiB);
|
2009-01-13 20:08:10 +01:00
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
2020-10-16 01:47:17 +02:00
|
|
|
memory_region_add_subregion(get_system_memory(), 0, machine->ram);
|
2008-12-21 00:40:35 +01:00
|
|
|
|
2020-10-17 17:47:29 +02:00
|
|
|
/* allocate and load firmware ROM */
|
|
|
|
memory_region_init_rom(bios, NULL, "ppc_heathrow.bios", PROM_SIZE,
|
Fix bad error handling after memory_region_init_ram()
Symptom:
$ qemu-system-x86_64 -m 10000000
Unexpected error in ram_block_add() at /work/armbru/qemu/exec.c:1456:
upstream-qemu: cannot set up guest memory 'pc.ram': Cannot allocate memory
Aborted (core dumped)
Root cause: commit ef701d7 screwed up handling of out-of-memory
conditions. Before the commit, we report the error and exit(1), in
one place, ram_block_add(). The commit lifts the error handling up
the call chain some, to three places. Fine. Except it uses
&error_abort in these places, changing the behavior from exit(1) to
abort(), and thus undoing the work of commit 3922825 "exec: Don't
abort when we can't allocate guest memory".
The three places are:
* memory_region_init_ram()
Commit 4994653 (right after commit ef701d7) lifted the error
handling further, through memory_region_init_ram(), multiplying the
incorrect use of &error_abort. Later on, imitation of existing
(bad) code may have created more.
* memory_region_init_ram_ptr()
The &error_abort is still there.
* memory_region_init_rom_device()
Doesn't need fixing, because commit 33e0eb5 (soon after commit
ef701d7) lifted the error handling further, and in the process
changed it from &error_abort to passing it up the call chain.
Correct, because the callers are realize() methods.
Fix the error handling after memory_region_init_ram() with a
Coccinelle semantic patch:
@r@
expression mr, owner, name, size, err;
position p;
@@
memory_region_init_ram(mr, owner, name, size,
(
- &error_abort
+ &error_fatal
|
err@p
)
);
@script:python@
p << r.p;
@@
print "%s:%s:%s" % (p[0].file, p[0].line, p[0].column)
When the last argument is &error_abort, it gets replaced by
&error_fatal. This is the fix.
If the last argument is anything else, its position is reported. This
lets us check the fix is complete. Four positions get reported:
* ram_backend_memory_alloc()
Error is passed up the call chain, ultimately through
user_creatable_complete(). As far as I can tell, it's callers all
handle the error sanely.
* fsl_imx25_realize(), fsl_imx31_realize(), dp8393x_realize()
DeviceClass.realize() methods, errors handled sanely further up the
call chain.
We're good. Test case again behaves:
$ qemu-system-x86_64 -m 10000000
qemu-system-x86_64: cannot set up guest memory 'pc.ram': Cannot allocate memory
[Exit 1 ]
The next commits will repair the rest of commit ef701d7's damage.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1441983105-26376-3-git-send-email-armbru@redhat.com>
Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
2015-09-11 16:51:43 +02:00
|
|
|
&error_fatal);
|
2020-10-16 01:47:17 +02:00
|
|
|
memory_region_add_subregion(get_system_memory(), PROM_BASE, bios);
|
ppc: fix -mem-path failure
commit e938ba0c tried to enable -mem-path for ppc but breaked some ppc
boards.
The problems are:
1. it fails when allocating memory for rom, sram whose sizes are less
than huge page size:
./ppc-softmmu/qemu-system-ppc -m 512 -mem-path /hugepages/ \
-kernel /home/hutao/Downloads/vmlinux-ppc -initrd \
/home/hutao/Downloads/initrd-ppc.gz
qemu-system-ppc: /mnt/data/projects/qemu/exec.c:1184: qemu_ram_set_idstr: Assertion `new_block' failed.
2. if there is a numa node backed by memory backend object, qemu fails
with message:
./ppc-softmmu/qemu-system-ppc -m 512 \
-object memory-backend-file,size=512M,mem-path=/hugepages,id=f0 \
-numa node,nodeid=0,memdev=f0 \
-kernel /home/hutao/Downloads/vmlinux-ppc \
-initrd /home/hutao/Downloads/initrd-ppc.gz
qemu-system-ppc: memory backend f0 is used multiple times. Each -numa option must use a different memdev value.
This patch does following:
1. replaces memory_region_allocate_system_memory() with
memory_region_init_ram() for rom, sram. Then only system memory
is backed by hugepages when specifying mem-path.
2. for memory banks, allocates all ram with
one memory_region_allocate_system_memory(), and use
memory_region_init_alias() to initialize memory banks.
Tested machines: default(g3beige), mac99, taihu, bamboo, ref405ep.
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
2014-07-21 11:30:17 +02:00
|
|
|
|
2020-10-17 17:47:29 +02:00
|
|
|
if (!bios_name) {
|
2008-12-24 21:23:51 +01:00
|
|
|
bios_name = PROM_FILENAME;
|
2020-10-17 17:47:29 +02:00
|
|
|
}
|
2009-05-30 01:52:44 +02:00
|
|
|
filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name);
|
|
|
|
if (filename) {
|
2020-10-17 17:47:29 +02:00
|
|
|
/* Load OpenBIOS (ELF) */
|
|
|
|
bios_size = load_elf(filename, NULL, NULL, NULL, NULL, &bios_addr,
|
|
|
|
NULL, NULL, 1, PPC_ELF_MACHINE, 0, 0);
|
|
|
|
/* Unfortunately, load_elf sign-extends reading elf32 */
|
|
|
|
bios_addr = (uint32_t)bios_addr;
|
|
|
|
|
|
|
|
if (bios_size <= 0) {
|
2020-10-16 01:47:17 +02:00
|
|
|
/* or if could not load ELF try loading a binary ROM image */
|
2020-10-17 17:47:29 +02:00
|
|
|
bios_size = load_image_targphys(filename, PROM_BASE, PROM_SIZE);
|
|
|
|
bios_addr = PROM_BASE;
|
|
|
|
}
|
2011-08-21 05:09:37 +02:00
|
|
|
g_free(filename);
|
2009-05-30 01:52:44 +02:00
|
|
|
} else {
|
|
|
|
bios_size = -1;
|
|
|
|
}
|
2020-10-17 17:47:29 +02:00
|
|
|
if (bios_size < 0 || bios_addr - PROM_BASE + bios_size > PROM_SIZE) {
|
2015-12-17 17:35:09 +01:00
|
|
|
error_report("could not load PowerPC bios '%s'", bios_name);
|
2007-10-29 00:42:18 +01:00
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
2020-10-16 01:47:17 +02:00
|
|
|
if (machine->kernel_filename) {
|
2009-09-20 16:58:02 +02:00
|
|
|
int bswap_needed;
|
|
|
|
|
|
|
|
#ifdef BSWAP_NEEDED
|
|
|
|
bswap_needed = 1;
|
|
|
|
#else
|
|
|
|
bswap_needed = 0;
|
|
|
|
#endif
|
2007-10-29 00:42:18 +01:00
|
|
|
kernel_base = KERNEL_LOAD_ADDR;
|
2020-10-16 01:47:17 +02:00
|
|
|
kernel_size = load_elf(machine->kernel_filename, NULL,
|
2020-07-05 19:22:11 +02:00
|
|
|
translate_kernel_address, NULL, NULL, NULL,
|
|
|
|
NULL, NULL, 1, PPC_ELF_MACHINE, 0, 0);
|
2008-12-24 21:30:01 +01:00
|
|
|
if (kernel_size < 0)
|
2020-10-16 01:47:17 +02:00
|
|
|
kernel_size = load_aout(machine->kernel_filename, kernel_base,
|
2009-09-20 16:58:02 +02:00
|
|
|
ram_size - kernel_base, bswap_needed,
|
|
|
|
TARGET_PAGE_SIZE);
|
2008-12-24 21:30:01 +01:00
|
|
|
if (kernel_size < 0)
|
2020-10-16 01:47:17 +02:00
|
|
|
kernel_size = load_image_targphys(machine->kernel_filename,
|
2008-12-24 21:30:01 +01:00
|
|
|
kernel_base,
|
|
|
|
ram_size - kernel_base);
|
2007-10-29 00:42:18 +01:00
|
|
|
if (kernel_size < 0) {
|
2020-10-16 01:47:17 +02:00
|
|
|
error_report("could not load kernel '%s'",
|
|
|
|
machine->kernel_filename);
|
2007-10-29 00:42:18 +01:00
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
/* load initrd */
|
2020-10-16 01:47:17 +02:00
|
|
|
if (machine->initrd_filename) {
|
|
|
|
initrd_base = TARGET_PAGE_ALIGN(kernel_base + kernel_size +
|
|
|
|
KERNEL_GAP);
|
|
|
|
initrd_size = load_image_targphys(machine->initrd_filename,
|
|
|
|
initrd_base,
|
2009-04-09 22:05:49 +02:00
|
|
|
ram_size - initrd_base);
|
2007-10-29 00:42:18 +01:00
|
|
|
if (initrd_size < 0) {
|
2015-12-17 17:35:09 +01:00
|
|
|
error_report("could not load initial ram disk '%s'",
|
2020-10-16 01:47:17 +02:00
|
|
|
machine->initrd_filename);
|
2007-10-29 00:42:18 +01:00
|
|
|
exit(1);
|
|
|
|
}
|
2017-09-11 22:16:10 +02:00
|
|
|
cmdline_base = TARGET_PAGE_ALIGN(initrd_base + initrd_size);
|
2007-10-29 00:42:18 +01:00
|
|
|
} else {
|
|
|
|
initrd_base = 0;
|
|
|
|
initrd_size = 0;
|
2017-09-11 22:16:10 +02:00
|
|
|
cmdline_base = TARGET_PAGE_ALIGN(kernel_base + kernel_size + KERNEL_GAP);
|
2007-10-29 00:42:18 +01:00
|
|
|
}
|
2007-10-31 02:54:04 +01:00
|
|
|
ppc_boot_device = 'm';
|
2007-10-29 00:42:18 +01:00
|
|
|
} else {
|
|
|
|
kernel_base = 0;
|
|
|
|
kernel_size = 0;
|
|
|
|
initrd_base = 0;
|
|
|
|
initrd_size = 0;
|
2007-11-11 02:50:45 +01:00
|
|
|
ppc_boot_device = '\0';
|
2007-11-11 15:44:28 +01:00
|
|
|
for (i = 0; boot_device[i] != '\0'; i++) {
|
2007-11-11 02:50:45 +01:00
|
|
|
/* TOFIX: for now, the second IDE channel is not properly
|
2007-11-11 15:44:28 +01:00
|
|
|
* used by OHW. The Mac floppy disk are not emulated.
|
2007-11-11 02:50:45 +01:00
|
|
|
* For now, OHW cannot boot from the network.
|
|
|
|
*/
|
|
|
|
#if 0
|
2007-11-11 15:44:28 +01:00
|
|
|
if (boot_device[i] >= 'a' && boot_device[i] <= 'f') {
|
|
|
|
ppc_boot_device = boot_device[i];
|
2007-11-11 02:50:45 +01:00
|
|
|
break;
|
2007-11-11 15:44:28 +01:00
|
|
|
}
|
2007-11-11 02:50:45 +01:00
|
|
|
#else
|
2007-11-11 15:44:28 +01:00
|
|
|
if (boot_device[i] >= 'c' && boot_device[i] <= 'd') {
|
|
|
|
ppc_boot_device = boot_device[i];
|
2007-11-11 02:50:45 +01:00
|
|
|
break;
|
2007-11-11 15:44:28 +01:00
|
|
|
}
|
2007-11-11 02:50:45 +01:00
|
|
|
#endif
|
|
|
|
}
|
|
|
|
if (ppc_boot_device == '\0') {
|
hw/ppc: Replace fprintf(stderr, "*\n" with error_report()
Replace a large number of the fprintf(stderr, "*\n" calls with
error_report(). The functions were renamed with these commands and then
compiler issues where manually fixed.
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
Some lines were then manually tweaked to pass checkpatch and some curly
braces were added to match QEMU style.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Cc: qemu-ppc@nongnu.org
Conversions that aren't followed by exit() dropped, because they might
be inappropriate.
Also trim trailing punctuation from error messages.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20180203084315.20497-10-armbru@redhat.com>
2018-02-03 09:43:10 +01:00
|
|
|
error_report("No valid boot device for G3 Beige machine");
|
2007-11-11 02:50:45 +01:00
|
|
|
exit(1);
|
|
|
|
}
|
2007-10-29 00:42:18 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/* XXX: we register only 1 output pin for heathrow PIC */
|
qdev: Convert uses of qdev_create() with Coccinelle
This is the transformation explained in the commit before previous.
Takes care of just one pattern that needs conversion. More to come in
this series.
Coccinelle script:
@ depends on !(file in "hw/arm/highbank.c")@
expression bus, type_name, dev, expr;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr;
identifier DOWN;
@@
- dev = DOWN(qdev_create(bus, type_name));
+ dev = DOWN(qdev_new(type_name));
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ qdev_realize_and_unref(DEVICE(dev), bus, &error_fatal);
@@
expression bus, type_name, expr;
identifier dev;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr, errp;
symbol true;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
@@
expression bus, type_name, expr, errp;
identifier dev;
symbol true;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
The first rule exempts hw/arm/highbank.c, because it matches along two
control flow paths there, with different @type_name. Covered by the
next commit's manual conversions.
Missing #include "qapi/error.h" added manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-10-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:31:58 +02:00
|
|
|
pic_dev = qdev_new(TYPE_HEATHROW);
|
sysbus: Convert to sysbus_realize() etc. with Coccinelle
Convert from qdev_realize(), qdev_realize_and_unref() with null @bus
argument to sysbus_realize(), sysbus_realize_and_unref().
Coccinelle script:
@@
expression dev, errp;
@@
- qdev_realize(DEVICE(dev), NULL, errp);
+ sysbus_realize(SYS_BUS_DEVICE(dev), errp);
@@
expression sysbus_dev, dev, errp;
@@
+ sysbus_dev = SYS_BUS_DEVICE(dev);
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
- sysbus_dev = SYS_BUS_DEVICE(dev);
@@
expression sysbus_dev, dev, errp;
expression expr;
@@
sysbus_dev = SYS_BUS_DEVICE(dev);
... when != dev = expr;
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(DEVICE(dev), NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
Whitespace changes minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-46-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:32:34 +02:00
|
|
|
sysbus_realize_and_unref(SYS_BUS_DEVICE(pic_dev), &error_fatal);
|
2018-03-06 23:01:54 +01:00
|
|
|
|
2007-10-29 00:42:18 +01:00
|
|
|
/* Connect the heathrow PIC outputs to the 6xx bus */
|
|
|
|
for (i = 0; i < smp_cpus; i++) {
|
|
|
|
switch (PPC_INPUT(env)) {
|
|
|
|
case PPC_FLAGS_INPUT_6xx:
|
2018-03-06 23:01:54 +01:00
|
|
|
qdev_connect_gpio_out(pic_dev, 0,
|
|
|
|
((qemu_irq *)env->irq_inputs)[PPC6xx_INPUT_INT]);
|
2007-10-29 00:42:18 +01:00
|
|
|
break;
|
|
|
|
default:
|
2015-12-17 17:35:09 +01:00
|
|
|
error_report("Bus model not supported on OldWorld Mac machine");
|
|
|
|
exit(1);
|
2007-10-29 00:42:18 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-07-13 22:29:02 +02:00
|
|
|
/* Timebase Frequency */
|
|
|
|
if (kvm_enabled()) {
|
|
|
|
tbfreq = kvmppc_get_tbfreq();
|
|
|
|
} else {
|
|
|
|
tbfreq = TBFREQ;
|
|
|
|
}
|
|
|
|
|
2007-10-29 00:42:18 +01:00
|
|
|
/* init basic PC hardware */
|
|
|
|
if (PPC_INPUT(env) != PPC_FLAGS_INPUT_6xx) {
|
2015-12-17 17:35:09 +01:00
|
|
|
error_report("Only 6xx bus is supported on heathrow machine");
|
|
|
|
exit(1);
|
2007-10-29 00:42:18 +01:00
|
|
|
}
|
2018-03-06 23:01:54 +01:00
|
|
|
|
2018-03-06 23:01:56 +01:00
|
|
|
/* Grackle PCI host bridge */
|
qdev: Convert uses of qdev_create() with Coccinelle
This is the transformation explained in the commit before previous.
Takes care of just one pattern that needs conversion. More to come in
this series.
Coccinelle script:
@ depends on !(file in "hw/arm/highbank.c")@
expression bus, type_name, dev, expr;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr;
identifier DOWN;
@@
- dev = DOWN(qdev_create(bus, type_name));
+ dev = DOWN(qdev_new(type_name));
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ qdev_realize_and_unref(DEVICE(dev), bus, &error_fatal);
@@
expression bus, type_name, expr;
identifier dev;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr, errp;
symbol true;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
@@
expression bus, type_name, expr, errp;
identifier dev;
symbol true;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
The first rule exempts hw/arm/highbank.c, because it matches along two
control flow paths there, with different @type_name. Covered by the
next commit's manual conversions.
Missing #include "qapi/error.h" added manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-10-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:31:58 +02:00
|
|
|
dev = qdev_new(TYPE_GRACKLE_PCI_HOST_BRIDGE);
|
2018-08-29 18:59:08 +02:00
|
|
|
qdev_prop_set_uint32(dev, "ofw-addr", 0x80000000);
|
2018-03-06 23:01:56 +01:00
|
|
|
s = SYS_BUS_DEVICE(dev);
|
sysbus: Convert to sysbus_realize() etc. with Coccinelle
Convert from qdev_realize(), qdev_realize_and_unref() with null @bus
argument to sysbus_realize(), sysbus_realize_and_unref().
Coccinelle script:
@@
expression dev, errp;
@@
- qdev_realize(DEVICE(dev), NULL, errp);
+ sysbus_realize(SYS_BUS_DEVICE(dev), errp);
@@
expression sysbus_dev, dev, errp;
@@
+ sysbus_dev = SYS_BUS_DEVICE(dev);
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
- sysbus_dev = SYS_BUS_DEVICE(dev);
@@
expression sysbus_dev, dev, errp;
expression expr;
@@
sysbus_dev = SYS_BUS_DEVICE(dev);
... when != dev = expr;
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(DEVICE(dev), NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
Whitespace changes minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-46-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:32:34 +02:00
|
|
|
sysbus_realize_and_unref(s, &error_fatal);
|
2020-10-13 13:49:21 +02:00
|
|
|
|
2018-03-06 23:01:56 +01:00
|
|
|
sysbus_mmio_map(s, 0, GRACKLE_BASE);
|
|
|
|
sysbus_mmio_map(s, 1, GRACKLE_BASE + 0x200000);
|
|
|
|
/* PCI hole */
|
|
|
|
memory_region_add_subregion(get_system_memory(), 0x80000000ULL,
|
|
|
|
sysbus_mmio_get_region(s, 2));
|
2018-03-06 23:01:57 +01:00
|
|
|
/* Register 2 MB of ISA IO space */
|
|
|
|
memory_region_add_subregion(get_system_memory(), 0xfe000000,
|
|
|
|
sysbus_mmio_get_region(s, 3));
|
2018-03-06 23:01:56 +01:00
|
|
|
|
2020-10-13 13:49:21 +02:00
|
|
|
for (i = 0; i < 4; i++) {
|
|
|
|
qdev_connect_gpio_out(dev, i, qdev_get_gpio_in(pic_dev, 0x15 + i));
|
|
|
|
}
|
|
|
|
|
2018-03-06 23:01:56 +01:00
|
|
|
pci_bus = PCI_HOST_BRIDGE(dev)->bus;
|
|
|
|
|
2012-09-08 12:21:20 +02:00
|
|
|
pci_vga_init(pci_bus);
|
2007-11-24 03:56:36 +01:00
|
|
|
|
2018-02-28 21:32:33 +01:00
|
|
|
for (i = 0; i < nb_nics; i++) {
|
2013-06-06 10:48:51 +02:00
|
|
|
pci_nic_init_nofail(&nd_table[i], pci_bus, "ne2k_pci", NULL);
|
2018-02-28 21:32:33 +01:00
|
|
|
}
|
2007-12-02 05:51:10 +01:00
|
|
|
|
2014-10-01 20:19:27 +02:00
|
|
|
ide_drive_get(hd, ARRAY_SIZE(hd));
|
2009-03-07 22:35:21 +01:00
|
|
|
|
2018-02-28 21:32:33 +01:00
|
|
|
/* MacIO */
|
2020-10-16 01:47:17 +02:00
|
|
|
macio = pci_new(PCI_DEVFN(16, 0), TYPE_OLDWORLD_MACIO);
|
2013-01-24 00:04:01 +01:00
|
|
|
dev = DEVICE(macio);
|
2014-07-13 22:31:53 +02:00
|
|
|
qdev_prop_set_uint64(dev, "frequency", tbfreq);
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-07 18:05:54 +02:00
|
|
|
object_property_set_link(OBJECT(macio), "pic", OBJECT(pic_dev),
|
2018-02-28 21:32:38 +01:00
|
|
|
&error_abort);
|
2020-10-13 13:49:20 +02:00
|
|
|
|
|
|
|
escc = ESCC(object_resolve_path_component(OBJECT(macio), "escc"));
|
|
|
|
qdev_prop_set_chr(DEVICE(escc), "chrA", serial_hd(0));
|
|
|
|
qdev_prop_set_chr(DEVICE(escc), "chrB", serial_hd(1));
|
|
|
|
|
pci: Convert uses of pci_create() etc. with Coccinelle
Replace
dev = pci_create(bus, type_name);
...
qdev_init_nofail(dev);
by
dev = pci_new(type_name);
...
pci_realize_and_unref(dev, bus, &error_fatal);
and similarly for pci_create_multifunction().
Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.
Coccinelle script:
@@
expression dev, bus, expr;
expression list args;
@@
- dev = pci_create(bus, args);
+ dev = pci_new(args);
... when != dev = expr
- qdev_init_nofail(&dev->qdev);
+ pci_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
expression d;
@@
- dev = pci_create(bus, args);
+ dev = pci_new(args);
(
d = &dev->qdev;
|
d = DEVICE(dev);
)
... when != dev = expr
- qdev_init_nofail(d);
+ pci_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = pci_create(bus, args);
+ dev = pci_new(args);
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ pci_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = DEVICE(pci_create(bus, args));
+ PCIDevice *pci_dev; // TODO move
+ pci_dev = pci_new(args);
+ dev = DEVICE(pci_dev);
... when != dev = expr
- qdev_init_nofail(dev);
+ pci_realize_and_unref(pci_dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = pci_create_multifunction(bus, args);
+ dev = pci_new_multifunction(args);
... when != dev = expr
- qdev_init_nofail(&dev->qdev);
+ pci_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, expr;
expression list args;
identifier dev;
@@
- PCIDevice *dev = pci_create_multifunction(bus, args);
+ PCIDevice *dev = pci_new_multifunction(args);
... when != dev = expr
- qdev_init_nofail(&dev->qdev);
+ pci_realize_and_unref(dev, bus, &error_fatal);
@@
expression dev, bus, expr;
expression list args;
@@
- dev = pci_create_multifunction(bus, args);
+ dev = pci_new_multifunction(args);
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ pci_realize_and_unref(dev, bus, &error_fatal);
Missing #include "qapi/error.h" added manually, whitespace changes
minimized manually, @pci_dev declarations moved manually.
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-16-armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
2020-06-10 07:32:04 +02:00
|
|
|
pci_realize_and_unref(macio, pci_bus, &error_fatal);
|
2013-01-24 00:04:01 +01:00
|
|
|
|
|
|
|
macio_ide = MACIO_IDE(object_resolve_path_component(OBJECT(macio),
|
2013-06-24 21:40:50 +02:00
|
|
|
"ide[0]"));
|
2013-01-24 00:04:01 +01:00
|
|
|
macio_ide_init_drives(macio_ide, hd);
|
|
|
|
|
2013-06-24 21:40:50 +02:00
|
|
|
macio_ide = MACIO_IDE(object_resolve_path_component(OBJECT(macio),
|
|
|
|
"ide[1]"));
|
|
|
|
macio_ide_init_drives(macio_ide, &hd[MAX_IDE_DEVS]);
|
2007-10-29 00:42:18 +01:00
|
|
|
|
2013-01-24 00:04:05 +01:00
|
|
|
dev = DEVICE(object_resolve_path_component(OBJECT(macio), "cuda"));
|
|
|
|
adb_bus = qdev_get_child_bus(dev, "adb.0");
|
qdev: Convert uses of qdev_create() with Coccinelle
This is the transformation explained in the commit before previous.
Takes care of just one pattern that needs conversion. More to come in
this series.
Coccinelle script:
@ depends on !(file in "hw/arm/highbank.c")@
expression bus, type_name, dev, expr;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr;
identifier DOWN;
@@
- dev = DOWN(qdev_create(bus, type_name));
+ dev = DOWN(qdev_new(type_name));
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ qdev_realize_and_unref(DEVICE(dev), bus, &error_fatal);
@@
expression bus, type_name, expr;
identifier dev;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr, errp;
symbol true;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
@@
expression bus, type_name, expr, errp;
identifier dev;
symbol true;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
The first rule exempts hw/arm/highbank.c, because it matches along two
control flow paths there, with different @type_name. Covered by the
next commit's manual conversions.
Missing #include "qapi/error.h" added manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-10-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:31:58 +02:00
|
|
|
dev = qdev_new(TYPE_ADB_KEYBOARD);
|
|
|
|
qdev_realize_and_unref(dev, adb_bus, &error_fatal);
|
|
|
|
dev = qdev_new(TYPE_ADB_MOUSE);
|
|
|
|
qdev_realize_and_unref(dev, adb_bus, &error_fatal);
|
2013-01-24 00:04:02 +01:00
|
|
|
|
2016-06-08 22:50:25 +02:00
|
|
|
if (machine_usb(machine)) {
|
2012-03-07 15:06:32 +01:00
|
|
|
pci_create_simple(pci_bus, -1, "pci-ohci");
|
2007-10-29 00:42:18 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
if (graphic_depth != 15 && graphic_depth != 32 && graphic_depth != 8)
|
|
|
|
graphic_depth = 15;
|
|
|
|
|
|
|
|
/* No PCI init: the BIOS will do it */
|
|
|
|
|
qdev: Convert uses of qdev_create() with Coccinelle
This is the transformation explained in the commit before previous.
Takes care of just one pattern that needs conversion. More to come in
this series.
Coccinelle script:
@ depends on !(file in "hw/arm/highbank.c")@
expression bus, type_name, dev, expr;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr;
identifier DOWN;
@@
- dev = DOWN(qdev_create(bus, type_name));
+ dev = DOWN(qdev_new(type_name));
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ qdev_realize_and_unref(DEVICE(dev), bus, &error_fatal);
@@
expression bus, type_name, expr;
identifier dev;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr, errp;
symbol true;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
@@
expression bus, type_name, expr, errp;
identifier dev;
symbol true;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
The first rule exempts hw/arm/highbank.c, because it matches along two
control flow paths there, with different @type_name. Covered by the
next commit's manual conversions.
Missing #include "qapi/error.h" added manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-10-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:31:58 +02:00
|
|
|
dev = qdev_new(TYPE_FW_CFG_MEM);
|
2018-08-10 12:27:56 +02:00
|
|
|
fw_cfg = FW_CFG(dev);
|
|
|
|
qdev_prop_set_uint32(dev, "data_width", 1);
|
|
|
|
qdev_prop_set_bit(dev, "dma_enabled", false);
|
|
|
|
object_property_add_child(OBJECT(qdev_get_machine()), TYPE_FW_CFG,
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 17:29:22 +02:00
|
|
|
OBJECT(fw_cfg));
|
2018-08-10 12:27:56 +02:00
|
|
|
s = SYS_BUS_DEVICE(dev);
|
sysbus: Convert to sysbus_realize() etc. with Coccinelle
Convert from qdev_realize(), qdev_realize_and_unref() with null @bus
argument to sysbus_realize(), sysbus_realize_and_unref().
Coccinelle script:
@@
expression dev, errp;
@@
- qdev_realize(DEVICE(dev), NULL, errp);
+ sysbus_realize(SYS_BUS_DEVICE(dev), errp);
@@
expression sysbus_dev, dev, errp;
@@
+ sysbus_dev = SYS_BUS_DEVICE(dev);
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
- sysbus_dev = SYS_BUS_DEVICE(dev);
@@
expression sysbus_dev, dev, errp;
expression expr;
@@
sysbus_dev = SYS_BUS_DEVICE(dev);
... when != dev = expr;
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(sysbus_dev, errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(DEVICE(dev), NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
@@
expression dev, errp;
@@
- qdev_realize_and_unref(dev, NULL, errp);
+ sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), errp);
Whitespace changes minimized manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-46-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
2020-06-10 07:32:34 +02:00
|
|
|
sysbus_realize_and_unref(s, &error_fatal);
|
2018-08-10 12:27:56 +02:00
|
|
|
sysbus_mmio_map(s, 0, CFG_ADDR);
|
|
|
|
sysbus_mmio_map(s, 1, CFG_ADDR + 2);
|
|
|
|
|
2016-11-15 13:17:15 +01:00
|
|
|
fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, (uint16_t)smp_cpus);
|
2019-05-18 22:54:22 +02:00
|
|
|
fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)machine->smp.max_cpus);
|
2008-12-24 21:29:16 +01:00
|
|
|
fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, (uint64_t)ram_size);
|
|
|
|
fw_cfg_add_i16(fw_cfg, FW_CFG_MACHINE_ID, ARCH_HEATHROW);
|
2009-03-08 10:51:29 +01:00
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_ADDR, kernel_base);
|
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_SIZE, kernel_size);
|
2020-10-16 01:47:17 +02:00
|
|
|
if (machine->kernel_cmdline) {
|
2011-06-15 23:27:19 +02:00
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_CMDLINE, cmdline_base);
|
2020-10-16 01:47:17 +02:00
|
|
|
pstrcpy_targphys("cmdline", cmdline_base, TARGET_PAGE_SIZE,
|
|
|
|
machine->kernel_cmdline);
|
2009-03-08 10:51:29 +01:00
|
|
|
} else {
|
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_CMDLINE, 0);
|
|
|
|
}
|
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_INITRD_ADDR, initrd_base);
|
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_INITRD_SIZE, initrd_size);
|
|
|
|
fw_cfg_add_i16(fw_cfg, FW_CFG_BOOT_DEVICE, ppc_boot_device);
|
2009-08-08 12:19:24 +02:00
|
|
|
|
|
|
|
fw_cfg_add_i16(fw_cfg, FW_CFG_PPC_WIDTH, graphic_width);
|
|
|
|
fw_cfg_add_i16(fw_cfg, FW_CFG_PPC_HEIGHT, graphic_height);
|
|
|
|
fw_cfg_add_i16(fw_cfg, FW_CFG_PPC_DEPTH, graphic_depth);
|
|
|
|
|
2010-08-03 15:22:42 +02:00
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_IS_KVM, kvm_enabled());
|
2010-02-09 17:37:05 +01:00
|
|
|
if (kvm_enabled()) {
|
2010-08-03 15:22:42 +02:00
|
|
|
uint8_t *hypercall;
|
|
|
|
|
2011-08-21 05:09:37 +02:00
|
|
|
hypercall = g_malloc(16);
|
2010-08-03 15:22:42 +02:00
|
|
|
kvmppc_get_hypercall(env, hypercall, 16);
|
|
|
|
fw_cfg_add_bytes(fw_cfg, FW_CFG_PPC_KVM_HC, hypercall, 16);
|
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_KVM_PID, getpid());
|
2010-02-09 17:37:05 +01:00
|
|
|
}
|
2014-07-13 22:29:02 +02:00
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_TBFREQ, tbfreq);
|
2013-06-23 00:22:50 +02:00
|
|
|
/* Mac OS X requires a "known good" clock-frequency value; pass it one. */
|
2014-04-17 19:04:44 +02:00
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_CLOCKFREQ, CLOCKFREQ);
|
|
|
|
fw_cfg_add_i32(fw_cfg, FW_CFG_PPC_BUSFREQ, BUSFREQ);
|
2010-02-09 17:37:05 +01:00
|
|
|
|
2017-05-01 15:43:32 +02:00
|
|
|
/* MacOS NDRV VGA driver */
|
|
|
|
filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, NDRV_VGA_FILENAME);
|
|
|
|
if (filename) {
|
2018-12-14 14:30:50 +01:00
|
|
|
gchar *ndrv_file;
|
|
|
|
gsize ndrv_size;
|
2017-05-01 15:43:32 +02:00
|
|
|
|
2018-12-14 14:30:50 +01:00
|
|
|
if (g_file_get_contents(filename, &ndrv_file, &ndrv_size, NULL)) {
|
2017-05-01 15:43:32 +02:00
|
|
|
fw_cfg_add_file(fw_cfg, "ndrv/qemu_vga.ndrv", ndrv_file, ndrv_size);
|
|
|
|
}
|
|
|
|
g_free(filename);
|
|
|
|
}
|
|
|
|
|
2009-03-08 10:51:29 +01:00
|
|
|
qemu_register_boot_set(fw_cfg_boot_set, fw_cfg);
|
2007-10-29 00:42:18 +01:00
|
|
|
}
|
|
|
|
|
2018-08-29 18:59:09 +02:00
|
|
|
/*
|
|
|
|
* Implementation of an interface to adjust firmware path
|
|
|
|
* for the bootindex property handling.
|
|
|
|
*/
|
|
|
|
static char *heathrow_fw_dev_path(FWPathProvider *p, BusState *bus,
|
|
|
|
DeviceState *dev)
|
|
|
|
{
|
|
|
|
PCIDevice *pci;
|
|
|
|
IDEBus *ide_bus;
|
|
|
|
IDEState *ide_s;
|
|
|
|
MACIOIDEState *macio_ide;
|
|
|
|
|
|
|
|
if (!strcmp(object_get_typename(OBJECT(dev)), "macio-oldworld")) {
|
|
|
|
pci = PCI_DEVICE(dev);
|
|
|
|
return g_strdup_printf("mac-io@%x", PCI_SLOT(pci->devfn));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!strcmp(object_get_typename(OBJECT(dev)), "macio-ide")) {
|
|
|
|
macio_ide = MACIO_IDE(dev);
|
|
|
|
return g_strdup_printf("ata-3@%x", macio_ide->addr);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!strcmp(object_get_typename(OBJECT(dev)), "ide-drive")) {
|
|
|
|
ide_bus = IDE_BUS(qdev_get_parent_bus(dev));
|
|
|
|
ide_s = idebus_active_if(ide_bus);
|
|
|
|
|
|
|
|
if (ide_s->drive_kind == IDE_CD) {
|
|
|
|
return g_strdup("cdrom");
|
|
|
|
}
|
|
|
|
|
2019-03-07 22:20:57 +01:00
|
|
|
return g_strdup("disk");
|
2018-08-29 18:59:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!strcmp(object_get_typename(OBJECT(dev)), "ide-hd")) {
|
2019-03-07 22:20:57 +01:00
|
|
|
return g_strdup("disk");
|
2018-08-29 18:59:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!strcmp(object_get_typename(OBJECT(dev)), "ide-cd")) {
|
|
|
|
return g_strdup("cdrom");
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!strcmp(object_get_typename(OBJECT(dev)), "virtio-blk-device")) {
|
|
|
|
return g_strdup("disk");
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2019-03-04 11:13:33 +01:00
|
|
|
static int heathrow_kvm_type(MachineState *machine, const char *arg)
|
2014-07-24 10:46:47 +02:00
|
|
|
{
|
|
|
|
/* Always force PR KVM */
|
|
|
|
return 2;
|
|
|
|
}
|
|
|
|
|
2017-09-17 19:15:41 +02:00
|
|
|
static void heathrow_class_init(ObjectClass *oc, void *data)
|
2015-09-04 20:37:08 +02:00
|
|
|
{
|
2017-09-17 19:15:41 +02:00
|
|
|
MachineClass *mc = MACHINE_CLASS(oc);
|
2018-08-29 18:59:09 +02:00
|
|
|
FWPathProviderClass *fwc = FW_PATH_PROVIDER_CLASS(oc);
|
2017-09-17 19:15:41 +02:00
|
|
|
|
2015-09-04 20:37:08 +02:00
|
|
|
mc->desc = "Heathrow based PowerMAC";
|
|
|
|
mc->init = ppc_heathrow_init;
|
2017-02-15 11:05:40 +01:00
|
|
|
mc->block_default_type = IF_IDE;
|
2015-09-04 20:37:08 +02:00
|
|
|
mc->max_cpus = MAX_CPUS;
|
2009-12-20 00:22:26 +01:00
|
|
|
#ifndef TARGET_PPC64
|
2020-02-07 17:19:47 +01:00
|
|
|
mc->is_default = true;
|
2009-12-20 00:22:26 +01:00
|
|
|
#endif
|
2015-09-04 20:37:07 +02:00
|
|
|
/* TOFIX "cad" when Mac floppy is implemented */
|
2015-09-04 20:37:08 +02:00
|
|
|
mc->default_boot_order = "cd";
|
|
|
|
mc->kvm_type = heathrow_kvm_type;
|
2017-10-09 21:50:53 +02:00
|
|
|
mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("750_v3.1");
|
2018-07-03 21:10:43 +02:00
|
|
|
mc->default_display = "std";
|
2018-08-29 18:59:09 +02:00
|
|
|
mc->ignore_boot_device_suffixes = true;
|
2020-02-19 17:09:35 +01:00
|
|
|
mc->default_ram_id = "ppc_heathrow.ram";
|
2018-08-29 18:59:09 +02:00
|
|
|
fwc->get_dev_path = heathrow_fw_dev_path;
|
2009-05-21 01:38:09 +02:00
|
|
|
}
|
|
|
|
|
2017-09-17 19:15:41 +02:00
|
|
|
static const TypeInfo ppc_heathrow_machine_info = {
|
|
|
|
.name = MACHINE_TYPE_NAME("g3beige"),
|
|
|
|
.parent = TYPE_MACHINE,
|
2018-08-29 18:59:09 +02:00
|
|
|
.class_init = heathrow_class_init,
|
|
|
|
.interfaces = (InterfaceInfo[]) {
|
|
|
|
{ TYPE_FW_PATH_PROVIDER },
|
|
|
|
{ }
|
|
|
|
},
|
2017-09-17 19:15:41 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
static void ppc_heathrow_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&ppc_heathrow_machine_info);
|
|
|
|
}
|
|
|
|
|
|
|
|
type_init(ppc_heathrow_register_types);
|