This website requires JavaScript.
Explore
Help
Sign In
haraldwolff
/
qemu-patch-raspberry4
Watch
1
Star
0
Fork
You've already forked qemu-patch-raspberry4
0
Code
Issues
Pull requests
Packages
Projects
Releases
Wiki
Activity
74a4320f30
qemu-patch-raspberry4
/
tests
/
qapi-schema
/
union-branch-case.json
3 lines
86 B
JSON
Raw
Normal View
History
Unescape
Escape
qapi: Clean up member name case checking QAPISchemaMember.check_clash() checks for member names that map to the same c_name(). Takes care of rejecting duplicate names. It also checks a naming rule: no uppercase in member names. That's a rather odd place to do it. Enforcing naming rules is check_name_str()'s job. qapi-code-gen.txt specifies the name case rule applies to the name as it appears in the schema. check_clash() checks c_name(name) instead. No difference, as c_name() leaves alone case, but unclean. Move the name case check into check_name_str(), less the c_name(). New argument @permit_upper suppresses it. Pass permit_upper=True for definitions (which are not members), and when the member's owner is whitelisted with pragma name-case-whitelist. Bonus: name-case-whitelist now applies to a union's inline base, too. Update qapi/qapi-schema.json pragma to whitelist union CpuInfo instead of CpuInfo's implicit base type's name q_obj_CpuInfo-base. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20190927134639.4284-6-armbru@redhat.com>
2019-09-27 15:46:18 +02:00
#
B
r
a
n
c
h
n
a
m
e
s
s
h
o
u
l
d
b
e
'
l
o
w
e
r
-
c
a
s
e
'
{
'
u
n
i
o
n
'
:
'
U
n
i
'
,
'
d
a
t
a
'
:
{
'
B
r
a
n
c
h
'
:
'
i
n
t
'
}
}
Reference in a new issue
Copy permalink