2016-06-08 20:55:29 +02:00
|
|
|
/*
|
|
|
|
* Copyright (C) 2016, Emilio G. Cota <cota@braap.org>
|
|
|
|
*
|
|
|
|
* License: GNU GPL, version 2 or later.
|
|
|
|
* See the COPYING file in the top-level directory.
|
|
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "qemu/qht.h"
|
2016-10-06 00:34:40 +02:00
|
|
|
#include "qemu/rcu.h"
|
2016-06-08 20:55:29 +02:00
|
|
|
|
|
|
|
#define N 5000
|
|
|
|
|
|
|
|
static struct qht ht;
|
|
|
|
static int32_t arr[N * 2];
|
|
|
|
|
2017-07-12 00:47:38 +02:00
|
|
|
static bool is_equal(const void *ap, const void *bp)
|
2016-06-08 20:55:29 +02:00
|
|
|
{
|
2017-07-12 00:47:38 +02:00
|
|
|
const int32_t *a = ap;
|
|
|
|
const int32_t *b = bp;
|
2016-06-08 20:55:29 +02:00
|
|
|
|
|
|
|
return *a == *b;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void insert(int a, int b)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = a; i < b; i++) {
|
|
|
|
uint32_t hash;
|
2017-07-12 00:48:21 +02:00
|
|
|
void *existing;
|
|
|
|
bool inserted;
|
2016-06-08 20:55:29 +02:00
|
|
|
|
|
|
|
arr[i] = i;
|
|
|
|
hash = i;
|
|
|
|
|
2017-07-12 00:48:21 +02:00
|
|
|
inserted = qht_insert(&ht, &arr[i], hash, NULL);
|
|
|
|
g_assert_true(inserted);
|
|
|
|
inserted = qht_insert(&ht, &arr[i], hash, &existing);
|
|
|
|
g_assert_false(inserted);
|
|
|
|
g_assert_true(existing == &arr[i]);
|
2016-06-08 20:55:29 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-08-15 23:56:26 +02:00
|
|
|
static void do_rm(int init, int end, bool exist)
|
2016-06-08 20:55:29 +02:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = init; i < end; i++) {
|
|
|
|
uint32_t hash;
|
|
|
|
|
|
|
|
hash = arr[i];
|
2018-08-15 23:56:26 +02:00
|
|
|
if (exist) {
|
|
|
|
g_assert_true(qht_remove(&ht, &arr[i], hash));
|
|
|
|
} else {
|
|
|
|
g_assert_false(qht_remove(&ht, &arr[i], hash));
|
|
|
|
}
|
2016-06-08 20:55:29 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-08-15 23:56:26 +02:00
|
|
|
static void rm(int init, int end)
|
|
|
|
{
|
|
|
|
do_rm(init, end, true);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void rm_nonexist(int init, int end)
|
|
|
|
{
|
|
|
|
do_rm(init, end, false);
|
|
|
|
}
|
|
|
|
|
2016-06-08 20:55:29 +02:00
|
|
|
static void check(int a, int b, bool expected)
|
|
|
|
{
|
|
|
|
struct qht_stats stats;
|
|
|
|
int i;
|
|
|
|
|
2016-10-06 00:34:40 +02:00
|
|
|
rcu_read_lock();
|
2016-06-08 20:55:29 +02:00
|
|
|
for (i = a; i < b; i++) {
|
|
|
|
void *p;
|
|
|
|
uint32_t hash;
|
|
|
|
int32_t val;
|
|
|
|
|
|
|
|
val = i;
|
|
|
|
hash = i;
|
2017-07-12 00:47:38 +02:00
|
|
|
/* test both lookup variants; results should be the same */
|
|
|
|
if (i % 2) {
|
|
|
|
p = qht_lookup(&ht, &val, hash);
|
|
|
|
} else {
|
|
|
|
p = qht_lookup_custom(&ht, &val, hash, is_equal);
|
|
|
|
}
|
2016-06-08 20:55:29 +02:00
|
|
|
g_assert_true(!!p == expected);
|
|
|
|
}
|
2016-10-06 00:34:40 +02:00
|
|
|
rcu_read_unlock();
|
|
|
|
|
2016-06-08 20:55:29 +02:00
|
|
|
qht_statistics_init(&ht, &stats);
|
|
|
|
if (stats.used_head_buckets) {
|
|
|
|
g_assert_cmpfloat(qdist_avg(&stats.chain), >=, 1.0);
|
|
|
|
}
|
|
|
|
g_assert_cmpuint(stats.head_buckets, >, 0);
|
|
|
|
qht_statistics_destroy(&stats);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void count_func(struct qht *ht, void *p, uint32_t hash, void *userp)
|
|
|
|
{
|
|
|
|
unsigned int *curr = userp;
|
|
|
|
|
|
|
|
(*curr)++;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void check_n(size_t expected)
|
|
|
|
{
|
|
|
|
struct qht_stats stats;
|
|
|
|
|
|
|
|
qht_statistics_init(&ht, &stats);
|
|
|
|
g_assert_cmpuint(stats.entries, ==, expected);
|
|
|
|
qht_statistics_destroy(&stats);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void iter_check(unsigned int count)
|
|
|
|
{
|
|
|
|
unsigned int curr = 0;
|
|
|
|
|
|
|
|
qht_iter(&ht, count_func, &curr);
|
|
|
|
g_assert_cmpuint(curr, ==, count);
|
|
|
|
}
|
|
|
|
|
2018-08-15 23:08:37 +02:00
|
|
|
static void sum_func(struct qht *ht, void *p, uint32_t hash, void *userp)
|
|
|
|
{
|
|
|
|
uint32_t *sum = userp;
|
|
|
|
uint32_t a = *(uint32_t *)p;
|
|
|
|
|
|
|
|
*sum += a;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void iter_sum_check(unsigned int expected)
|
|
|
|
{
|
|
|
|
unsigned int sum = 0;
|
|
|
|
|
|
|
|
qht_iter(&ht, sum_func, &sum);
|
|
|
|
g_assert_cmpuint(sum, ==, expected);
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool rm_mod_func(struct qht *ht, void *p, uint32_t hash, void *userp)
|
|
|
|
{
|
|
|
|
uint32_t a = *(uint32_t *)p;
|
|
|
|
unsigned int mod = *(unsigned int *)userp;
|
|
|
|
|
|
|
|
return a % mod == 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void iter_rm_mod(unsigned int mod)
|
|
|
|
{
|
|
|
|
qht_iter_remove(&ht, rm_mod_func, &mod);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void iter_rm_mod_check(unsigned int mod)
|
|
|
|
{
|
|
|
|
unsigned int expected = 0;
|
|
|
|
unsigned int i;
|
|
|
|
|
|
|
|
for (i = 0; i < N; i++) {
|
|
|
|
if (i % mod == 0) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
expected += i;
|
|
|
|
}
|
|
|
|
iter_sum_check(expected);
|
|
|
|
}
|
|
|
|
|
2016-06-08 20:55:29 +02:00
|
|
|
static void qht_do_test(unsigned int mode, size_t init_entries)
|
|
|
|
{
|
qht: do not segfault when gathering stats from an uninitialized qht
So far, QHT functions assume that the passed qht has previously been
initialized--otherwise they segfault.
This patch makes an exception for qht_statistics_init, with the goal
of simplifying calling code. For instance, qht_statistics_init is
called from the 'info jit' dump, and given that under KVM the TB qht
is never initialized, we get a segfault. Thus, instead of complicating
the 'info jit' code with additional checks, let's allow passing an
uninitialized qht to qht_statistics_init.
While at it, add a test for this to test-qht.
Before the patch (for $ qemu -enable-kvm [...]):
(qemu) info jit
[...]
direct jump count 0 (0%) (2 jumps=0 0%)
Program received signal SIGSEGV, Segmentation fault.
After the patch the "TB hash buckets", "TB hash occupancy"
and "TB hash avg chain" lines are omitted.
(qemu) info jit
[...]
direct jump count 0 (0%) (2 jumps=0 0%)
TB hash buckets 0/0 (-nan% head buckets used)
TB hash occupancy nan% avg chain occ. Histogram: (null)
TB hash avg chain nan buckets. Histogram: (null)
[...]
Reported by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Message-Id: <1469205390-14369-1-git-send-email-cota@braap.org>
[Extract printing statistics to an entirely separate function. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-07-22 18:36:30 +02:00
|
|
|
/* under KVM we might fetch stats from an uninitialized qht */
|
|
|
|
check_n(0);
|
|
|
|
|
2017-07-12 00:47:38 +02:00
|
|
|
qht_init(&ht, is_equal, 0, mode);
|
2018-08-15 23:56:26 +02:00
|
|
|
rm_nonexist(0, 4);
|
2018-08-18 00:15:33 +02:00
|
|
|
/*
|
|
|
|
* Test that we successfully delete the last element in a bucket.
|
|
|
|
* This is a hard-to-reach code path when resizing is on, but without
|
|
|
|
* resizing we can easily hit it if init_entries <= 1.
|
|
|
|
* Given that the number of elements per bucket can be 4 or 6 depending on
|
|
|
|
* the host's pointer size, test the removal of the 4th and 6th elements.
|
|
|
|
*/
|
2018-08-15 23:56:26 +02:00
|
|
|
insert(0, 4);
|
|
|
|
rm_nonexist(5, 6);
|
2018-08-18 00:15:33 +02:00
|
|
|
rm(3, 4);
|
|
|
|
check_n(3);
|
|
|
|
insert(3, 6);
|
|
|
|
rm(5, 6);
|
|
|
|
check_n(5);
|
2018-08-15 23:56:26 +02:00
|
|
|
rm_nonexist(7, 8);
|
|
|
|
iter_rm_mod(1);
|
2016-06-08 20:55:29 +02:00
|
|
|
|
2018-08-18 00:15:52 +02:00
|
|
|
if (!(mode & QHT_MODE_AUTO_RESIZE)) {
|
|
|
|
qht_resize(&ht, init_entries * 4 + 4);
|
|
|
|
}
|
|
|
|
|
qht: do not segfault when gathering stats from an uninitialized qht
So far, QHT functions assume that the passed qht has previously been
initialized--otherwise they segfault.
This patch makes an exception for qht_statistics_init, with the goal
of simplifying calling code. For instance, qht_statistics_init is
called from the 'info jit' dump, and given that under KVM the TB qht
is never initialized, we get a segfault. Thus, instead of complicating
the 'info jit' code with additional checks, let's allow passing an
uninitialized qht to qht_statistics_init.
While at it, add a test for this to test-qht.
Before the patch (for $ qemu -enable-kvm [...]):
(qemu) info jit
[...]
direct jump count 0 (0%) (2 jumps=0 0%)
Program received signal SIGSEGV, Segmentation fault.
After the patch the "TB hash buckets", "TB hash occupancy"
and "TB hash avg chain" lines are omitted.
(qemu) info jit
[...]
direct jump count 0 (0%) (2 jumps=0 0%)
TB hash buckets 0/0 (-nan% head buckets used)
TB hash occupancy nan% avg chain occ. Histogram: (null)
TB hash avg chain nan buckets. Histogram: (null)
[...]
Reported by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Message-Id: <1469205390-14369-1-git-send-email-cota@braap.org>
[Extract printing statistics to an entirely separate function. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-07-22 18:36:30 +02:00
|
|
|
check_n(0);
|
2018-08-15 23:56:26 +02:00
|
|
|
rm_nonexist(0, 10);
|
2016-06-08 20:55:29 +02:00
|
|
|
insert(0, N);
|
|
|
|
check(0, N, true);
|
|
|
|
check_n(N);
|
|
|
|
check(-N, -1, false);
|
|
|
|
iter_check(N);
|
|
|
|
|
|
|
|
rm(101, 102);
|
|
|
|
check_n(N - 1);
|
|
|
|
insert(N, N * 2);
|
|
|
|
check_n(N + N - 1);
|
|
|
|
rm(N, N * 2);
|
|
|
|
check_n(N - 1);
|
|
|
|
insert(101, 102);
|
|
|
|
check_n(N);
|
|
|
|
|
|
|
|
rm(10, 200);
|
|
|
|
check_n(N - 190);
|
|
|
|
insert(150, 200);
|
|
|
|
check_n(N - 190 + 50);
|
|
|
|
insert(10, 150);
|
|
|
|
check_n(N);
|
|
|
|
|
2018-08-15 23:08:37 +02:00
|
|
|
qht_reset(&ht);
|
|
|
|
insert(0, N);
|
2018-08-15 23:56:26 +02:00
|
|
|
rm_nonexist(N, N + 32);
|
2018-08-15 23:08:37 +02:00
|
|
|
iter_rm_mod(10);
|
|
|
|
iter_rm_mod_check(10);
|
|
|
|
check_n(N * 9 / 10);
|
2016-06-08 20:55:29 +02:00
|
|
|
qht_reset_size(&ht, 0);
|
|
|
|
check_n(0);
|
|
|
|
check(0, N, false);
|
|
|
|
|
|
|
|
qht_destroy(&ht);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void qht_test(unsigned int mode)
|
|
|
|
{
|
|
|
|
qht_do_test(mode, 0);
|
|
|
|
qht_do_test(mode, 1);
|
|
|
|
qht_do_test(mode, 2);
|
|
|
|
qht_do_test(mode, 8);
|
|
|
|
qht_do_test(mode, 16);
|
|
|
|
qht_do_test(mode, 8192);
|
|
|
|
qht_do_test(mode, 16384);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void test_default(void)
|
|
|
|
{
|
|
|
|
qht_test(0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void test_resize(void)
|
|
|
|
{
|
|
|
|
qht_test(QHT_MODE_AUTO_RESIZE);
|
|
|
|
}
|
|
|
|
|
|
|
|
int main(int argc, char *argv[])
|
|
|
|
{
|
|
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
g_test_add_func("/qht/mode/default", test_default);
|
|
|
|
g_test_add_func("/qht/mode/resize", test_resize);
|
|
|
|
return g_test_run();
|
|
|
|
}
|