rdma: check num_sge does not exceed MAX_SGE
rdma back-end has scatter/gather array ibv_sge[MAX_SGE=4] set to have 4 elements. A guest could send a 'PvrdmaSqWqe' ring element with 'num_sge' set to > MAX_SGE, which may lead to OOB access issue. Add check to avoid it. Reported-by: Saar Amar <saaramar5@gmail.com> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
This commit is contained in:
parent
cce648613b
commit
0e68373cc2
|
@ -476,9 +476,9 @@ void rdma_backend_post_send(RdmaBackendDev *backend_dev,
|
||||||
}
|
}
|
||||||
|
|
||||||
pr_dbg("num_sge=%d\n", num_sge);
|
pr_dbg("num_sge=%d\n", num_sge);
|
||||||
if (!num_sge) {
|
if (!num_sge || num_sge > MAX_SGE) {
|
||||||
pr_dbg("num_sge=0\n");
|
pr_dbg("invalid num_sge=%d\n", num_sge);
|
||||||
complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx);
|
complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -603,9 +603,9 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev,
|
||||||
}
|
}
|
||||||
|
|
||||||
pr_dbg("num_sge=%d\n", num_sge);
|
pr_dbg("num_sge=%d\n", num_sge);
|
||||||
if (!num_sge) {
|
if (!num_sge || num_sge > MAX_SGE) {
|
||||||
pr_dbg("num_sge=0\n");
|
pr_dbg("invalid num_sge=%d\n", num_sge);
|
||||||
complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx);
|
complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx);
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue