hw/core/generic-loader: Compile only once, not for each target
The generic-loader is currently compiled target specific due to one single "#ifdef TARGET_WORDS_BIGENDIAN" in the file. We have already a function called target_words_bigendian() for this instead, so we can put the generic-loader into common-obj to save some compilation time. Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
parent
c95ac10340
commit
1a1ff38c55
|
@ -20,6 +20,6 @@ common-obj-$(CONFIG_SOFTMMU) += register.o
|
||||||
common-obj-$(CONFIG_SOFTMMU) += or-irq.o
|
common-obj-$(CONFIG_SOFTMMU) += or-irq.o
|
||||||
common-obj-$(CONFIG_SOFTMMU) += split-irq.o
|
common-obj-$(CONFIG_SOFTMMU) += split-irq.o
|
||||||
common-obj-$(CONFIG_PLATFORM_BUS) += platform-bus.o
|
common-obj-$(CONFIG_PLATFORM_BUS) += platform-bus.o
|
||||||
|
common-obj-$(CONFIG_SOFTMMU) += generic-loader.o
|
||||||
|
|
||||||
obj-$(CONFIG_SOFTMMU) += generic-loader.o
|
|
||||||
obj-$(CONFIG_SOFTMMU) += null-machine.o
|
obj-$(CONFIG_SOFTMMU) += null-machine.o
|
||||||
|
|
|
@ -130,11 +130,7 @@ static void generic_loader_realize(DeviceState *dev, Error **errp)
|
||||||
s->cpu = first_cpu;
|
s->cpu = first_cpu;
|
||||||
}
|
}
|
||||||
|
|
||||||
#ifdef TARGET_WORDS_BIGENDIAN
|
big_endian = target_words_bigendian();
|
||||||
big_endian = 1;
|
|
||||||
#else
|
|
||||||
big_endian = 0;
|
|
||||||
#endif
|
|
||||||
|
|
||||||
if (s->file) {
|
if (s->file) {
|
||||||
AddressSpace *as = s->cpu ? s->cpu->as : NULL;
|
AddressSpace *as = s->cpu ? s->cpu->as : NULL;
|
||||||
|
|
Loading…
Reference in a new issue