Delayed IP packets

In the current implementation, if Slirp tries to send an IP packet to a client
with an unknown hardware address, the packet is simply dropped and an ARP
request is sent (if_encap in slirp/slirp.c).

With this patch, Slirp will send the ARP request, re-queue the packet and try
to send it later. The packet is dropped after one second if the ARP reply is
not received.

Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

slirp/if.c

@@ -6,6 +6,7 @@
  */
 
 #include <slirp.h>
+#include "qemu-timer.h"
 
 #define ifs_init(ifm) ((ifm)->ifs_next = (ifm)->ifs_prev = (ifm))
 
@@ -105,6 +106,9 @@ if_output(struct socket *so, struct mbuf *ifm)
 	ifs_init(ifm);
 	insque(ifm, ifq);
 
+        /* Expiration date = Now + 1 second */
+        ifm->expiration_date = qemu_get_clock_ns(rt_clock) + 1000000000ULL;
+
 diddit:
 	slirp->if_queued++;
 
@@ -153,6 +157,9 @@ diddit:
 void
 if_start(Slirp *slirp)
 {
+    int requeued = 0;
+    uint64_t now;
+
 	struct mbuf *ifm, *ifqt;
 
 	DEBUG_CALL("if_start");
@@ -165,6 +172,8 @@ if_start(Slirp *slirp)
         if (!slirp_can_output(slirp->opaque))
             return;
 
+        now = qemu_get_clock_ns(rt_clock);
+
 	/*
 	 * See which queue to get next packet from
 	 * If there's something in the fastq, select it immediately
@@ -199,11 +208,22 @@ if_start(Slirp *slirp)
 		   ifm->ifq_so->so_nqueued = 0;
 	}
 
-	/* Encapsulate the packet for sending */
+        if (ifm->expiration_date < now) {
-        if_encap(slirp, (uint8_t *)ifm->m_data, ifm->m_len);
+            /* Expired */
-
+            m_free(ifm);
-        m_free(ifm);
+        } else {
+            /* Encapsulate the packet for sending */
+            if (if_encap(slirp, ifm)) {
+                m_free(ifm);
+            } else {
+                /* re-queue */
+                insque(ifm, ifqt);
+                requeued++;
+            }
+        }
 
 	if (slirp->if_queued)
 	   goto again;
+
+        slirp->if_queued = requeued;
 }

slirp/main.h

@@ -42,5 +42,5 @@ extern int tcp_keepintvl;
 #define PROTO_PPP 0x2
 #endif
 
-void if_encap(Slirp *slirp, const uint8_t *ip_data, int ip_data_len);
+int if_encap(Slirp *slirp, struct mbuf *ifm);
 ssize_t slirp_send(struct socket *so, const void *buf, size_t len, int flags);

slirp/mbuf.c

@@ -70,6 +70,8 @@ m_get(Slirp *slirp)
 	m->m_len = 0;
         m->m_nextpkt = NULL;
         m->m_prevpkt = NULL;
+        m->arp_requested = false;
+        m->expiration_date = (uint64_t)-1;
 end_error:
 	DEBUG_ARG("m = %lx", (long )m);
 	return m;

slirp/mbuf.h

@@ -86,6 +86,8 @@ struct mbuf {
 		char	m_dat_[1]; /* ANSI don't like 0 sized arrays */
 		char	*m_ext_;
 	} M_dat;
+    bool     arp_requested;
+    uint64_t expiration_date;
 };
 
 #define m_next		m_hdr.mh_next

slirp/slirp.c

@@ -692,55 +692,63 @@ void slirp_input(Slirp *slirp, const uint8_t *pkt, int pkt_len)
     }
 }
 
-/* output the IP packet to the ethernet device */
+/* Output the IP packet to the ethernet device. Returns 0 if the packet must be
-void if_encap(Slirp *slirp, const uint8_t *ip_data, int ip_data_len)
+ * re-queued.
+ */
+int if_encap(Slirp *slirp, struct mbuf *ifm)
 {
     uint8_t buf[1600];
     struct ethhdr *eh = (struct ethhdr *)buf;
     uint8_t ethaddr[ETH_ALEN];
-    const struct ip *iph = (const struct ip *)ip_data;
+    const struct ip *iph = (const struct ip *)ifm->m_data;
 
-    if (ip_data_len + ETH_HLEN > sizeof(buf))
+    if (ifm->m_len + ETH_HLEN > sizeof(buf)) {
-        return;
+        return 1;
+    }
 
     if (!arp_table_search(slirp, iph->ip_dst.s_addr, ethaddr)) {
         uint8_t arp_req[ETH_HLEN + sizeof(struct arphdr)];
         struct ethhdr *reh = (struct ethhdr *)arp_req;
         struct arphdr *rah = (struct arphdr *)(arp_req + ETH_HLEN);
 
-        /* If the client addr is not known, there is no point in
+        if (!ifm->arp_requested) {
-           sending the packet to it. Normally the sender should have
+            /* If the client addr is not known, send an ARP request */
-           done an ARP request to get its MAC address. Here we do it
+            memset(reh->h_dest, 0xff, ETH_ALEN);
-           in place of sending the packet and we hope that the sender
+            memcpy(reh->h_source, special_ethaddr, ETH_ALEN - 4);
-           will retry sending its packet. */
+            memcpy(&reh->h_source[2], &slirp->vhost_addr, 4);
-        memset(reh->h_dest, 0xff, ETH_ALEN);
+            reh->h_proto = htons(ETH_P_ARP);
-        memcpy(reh->h_source, special_ethaddr, ETH_ALEN - 4);
+            rah->ar_hrd = htons(1);
-        memcpy(&reh->h_source[2], &slirp->vhost_addr, 4);
+            rah->ar_pro = htons(ETH_P_IP);
-        reh->h_proto = htons(ETH_P_ARP);
+            rah->ar_hln = ETH_ALEN;
-        rah->ar_hrd = htons(1);
+            rah->ar_pln = 4;
-        rah->ar_pro = htons(ETH_P_IP);
+            rah->ar_op = htons(ARPOP_REQUEST);
-        rah->ar_hln = ETH_ALEN;
+
-        rah->ar_pln = 4;
+            /* source hw addr */
-        rah->ar_op = htons(ARPOP_REQUEST);
+            memcpy(rah->ar_sha, special_ethaddr, ETH_ALEN - 4);
-        /* source hw addr */
+            memcpy(&rah->ar_sha[2], &slirp->vhost_addr, 4);
-        memcpy(rah->ar_sha, special_ethaddr, ETH_ALEN - 4);
+
-        memcpy(&rah->ar_sha[2], &slirp->vhost_addr, 4);
+            /* source IP */
-        /* source IP */
+            rah->ar_sip = slirp->vhost_addr.s_addr;
-        rah->ar_sip = slirp->vhost_addr.s_addr;
+
-        /* target hw addr (none) */
+            /* target hw addr (none) */
-        memset(rah->ar_tha, 0, ETH_ALEN);
+            memset(rah->ar_tha, 0, ETH_ALEN);
-        /* target IP */
+
-        rah->ar_tip = iph->ip_dst.s_addr;
+            /* target IP */
-        slirp->client_ipaddr = iph->ip_dst;
+            rah->ar_tip = iph->ip_dst.s_addr;
-        slirp_output(slirp->opaque, arp_req, sizeof(arp_req));
+            slirp->client_ipaddr = iph->ip_dst;
+            slirp_output(slirp->opaque, arp_req, sizeof(arp_req));
+            ifm->arp_requested = true;
+        }
+        return 0;
     } else {
         memcpy(eh->h_dest, ethaddr, ETH_ALEN);
         memcpy(eh->h_source, special_ethaddr, ETH_ALEN - 4);
         /* XXX: not correct */
         memcpy(&eh->h_source[2], &slirp->vhost_addr, 4);
         eh->h_proto = htons(ETH_P_IP);
-        memcpy(buf + sizeof(struct ethhdr), ip_data, ip_data_len);
+        memcpy(buf + sizeof(struct ethhdr), ifm->m_data, ifm->m_len);
-        slirp_output(slirp->opaque, buf, ip_data_len + ETH_HLEN);
+        slirp_output(slirp->opaque, buf, ifm->m_len + ETH_HLEN);
+        return 1;
     }
 }