pvrdma: check number of pages when creating rings
When creating CQ/QP rings, an object can have up to PVRDMA_MAX_FAST_REG_PAGES 8 pages. Check 'npages' parameter to avoid excessive memory allocation or a null dereference. Reported-by: Li Qiang <liq3ea@163.com> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
This commit is contained in:
parent
2aa86456fb
commit
2c858ce5da
|
@ -259,6 +259,11 @@ static int create_cq_ring(PCIDevice *pci_dev , PvrdmaRing **ring,
|
||||||
int rc = -EINVAL;
|
int rc = -EINVAL;
|
||||||
char ring_name[MAX_RING_NAME_SZ];
|
char ring_name[MAX_RING_NAME_SZ];
|
||||||
|
|
||||||
|
if (!nchunks || nchunks > PVRDMA_MAX_FAST_REG_PAGES) {
|
||||||
|
pr_dbg("invalid nchunks: %d\n", nchunks);
|
||||||
|
return rc;
|
||||||
|
}
|
||||||
|
|
||||||
pr_dbg("pdir_dma=0x%llx\n", (long long unsigned int)pdir_dma);
|
pr_dbg("pdir_dma=0x%llx\n", (long long unsigned int)pdir_dma);
|
||||||
dir = rdma_pci_dma_map(pci_dev, pdir_dma, TARGET_PAGE_SIZE);
|
dir = rdma_pci_dma_map(pci_dev, pdir_dma, TARGET_PAGE_SIZE);
|
||||||
if (!dir) {
|
if (!dir) {
|
||||||
|
@ -372,6 +377,12 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma,
|
||||||
char ring_name[MAX_RING_NAME_SZ];
|
char ring_name[MAX_RING_NAME_SZ];
|
||||||
uint32_t wqe_sz;
|
uint32_t wqe_sz;
|
||||||
|
|
||||||
|
if (!spages || spages > PVRDMA_MAX_FAST_REG_PAGES
|
||||||
|
|| !rpages || rpages > PVRDMA_MAX_FAST_REG_PAGES) {
|
||||||
|
pr_dbg("invalid pages: %d, %d\n", spages, rpages);
|
||||||
|
return rc;
|
||||||
|
}
|
||||||
|
|
||||||
pr_dbg("pdir_dma=0x%llx\n", (long long unsigned int)pdir_dma);
|
pr_dbg("pdir_dma=0x%llx\n", (long long unsigned int)pdir_dma);
|
||||||
dir = rdma_pci_dma_map(pci_dev, pdir_dma, TARGET_PAGE_SIZE);
|
dir = rdma_pci_dma_map(pci_dev, pdir_dma, TARGET_PAGE_SIZE);
|
||||||
if (!dir) {
|
if (!dir) {
|
||||||
|
|
Loading…
Reference in a new issue