haraldwolff/qemu-patch-raspberry4
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix harmless if statements with empty body, spotted by clang

Browse source 
These clang errors are harmless but worth fixing:
  CC    libhw64/fdc.o
/src/qemu/hw/fdc.c:998:74: error: if statement has empty body [-Wempty-body]
        FLOPPY_DPRINTF("Floppy digital input register: 0x%02x\n", retval);
  CC    libhw64/cuda.o
/src/qemu/hw/cuda.c:320:66: error: if statement has empty body [-Wempty-body]
        CUDA_DPRINTF("read: reg=0x%x val=%02x\n", (int)addr, val);

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
This commit is contained in:
Blue Swirl 2010-04-18 08:45:03 +00:00
parent 606257c6f2
commit 3c83eb4f17
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
hw/cuda.c
View file

@ -316,8 +316,10 @@ static uint32_t cuda_readb(void *opaque, target_phys_addr_t addr)
val = s->anh; val = s->anh;
break; break;
} }
if (addr != 13 || val != 0) if (addr != 13 || val != 0) {
CUDA_DPRINTF("read: reg=0x%x val=%02x\n", (int)addr, val); CUDA_DPRINTF("read: reg=0x%x val=%02x\n", (int)addr, val);
}
return val; return val;
} }

3
hw/fdc.c
View file

@ -994,8 +994,9 @@ static uint32_t fdctrl_read_dir(FDCtrl *fdctrl)
#endif #endif
) )
retval |= FD_DIR_DSKCHG; retval |= FD_DIR_DSKCHG;
if (retval != 0) if (retval != 0) {
FLOPPY_DPRINTF("Floppy digital input register: 0x%02x\n", retval); FLOPPY_DPRINTF("Floppy digital input register: 0x%02x\n", retval);
}
return retval; return retval;
} }