hw/arm/armsse: Assert info->num_cpus is in-bounds in armsse_realize()
In armsse_realize() we have a loop over [0, info->num_cpus), which indexes into various fixed-size arrays in the ARMSSE struct. This confuses Coverity, which warns that we might overrun those arrays (CID 1430326, 1430337, 1430371, 1430414, 1430430). This can't actually happen, because the info struct is always one of the entries in the armsse_variants[] array and num_cpus is either 1 or 2; we also already assert in armsse_init() that num_cpus is not too large. However, adding an assert to armsse_realize() like the one in armsse_init() should help Coverity figure out that these code paths aren't possible. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-id: 20200713143716.9881-1-peter.maydell@linaro.org
This commit is contained in:
parent
cd07d7f9f5
commit
3f410039b7
|
@ -452,6 +452,8 @@ static void armsse_realize(DeviceState *dev, Error **errp)
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
assert(info->num_cpus <= SSE_MAX_CPUS);
|
||||||
|
|
||||||
/* max SRAM_ADDR_WIDTH: 24 - log2(SRAM_NUM_BANK) */
|
/* max SRAM_ADDR_WIDTH: 24 - log2(SRAM_NUM_BANK) */
|
||||||
assert(is_power_of_2(info->sram_banks));
|
assert(is_power_of_2(info->sram_banks));
|
||||||
addr_width_max = 24 - ctz32(info->sram_banks);
|
addr_width_max = 24 - ctz32(info->sram_banks);
|
||||||
|
|
Loading…
Reference in a new issue