rtl8139: fix clang reporting unused assignment of VLAN tagging data
Currently we do not implement VLAN tagging for rtl8139(C+), still data is read from ring buffer headers. - augment unused assignment with TODO item - cast txdw1 to void for now Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
parent
7b8737de03
commit
4ef1a3d3b3
|
@ -1909,6 +1909,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
|
||||||
|
|
||||||
cpu_physical_memory_read(cplus_tx_ring_desc, (uint8_t *)&val, 4);
|
cpu_physical_memory_read(cplus_tx_ring_desc, (uint8_t *)&val, 4);
|
||||||
txdw0 = le32_to_cpu(val);
|
txdw0 = le32_to_cpu(val);
|
||||||
|
/* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */
|
||||||
cpu_physical_memory_read(cplus_tx_ring_desc+4, (uint8_t *)&val, 4);
|
cpu_physical_memory_read(cplus_tx_ring_desc+4, (uint8_t *)&val, 4);
|
||||||
txdw1 = le32_to_cpu(val);
|
txdw1 = le32_to_cpu(val);
|
||||||
cpu_physical_memory_read(cplus_tx_ring_desc+8, (uint8_t *)&val, 4);
|
cpu_physical_memory_read(cplus_tx_ring_desc+8, (uint8_t *)&val, 4);
|
||||||
|
@ -1920,6 +1921,9 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
|
||||||
descriptor,
|
descriptor,
|
||||||
txdw0, txdw1, txbufLO, txbufHI));
|
txdw0, txdw1, txbufLO, txbufHI));
|
||||||
|
|
||||||
|
/* TODO: the following discard cast should clean clang analyzer output */
|
||||||
|
(void)txdw1;
|
||||||
|
|
||||||
/* w0 ownership flag */
|
/* w0 ownership flag */
|
||||||
#define CP_TX_OWN (1<<31)
|
#define CP_TX_OWN (1<<31)
|
||||||
/* w0 end of ring flag */
|
/* w0 end of ring flag */
|
||||||
|
@ -2045,6 +2049,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
|
||||||
/* update ring data */
|
/* update ring data */
|
||||||
val = cpu_to_le32(txdw0);
|
val = cpu_to_le32(txdw0);
|
||||||
cpu_physical_memory_write(cplus_tx_ring_desc, (uint8_t *)&val, 4);
|
cpu_physical_memory_write(cplus_tx_ring_desc, (uint8_t *)&val, 4);
|
||||||
|
/* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */
|
||||||
// val = cpu_to_le32(txdw1);
|
// val = cpu_to_le32(txdw1);
|
||||||
// cpu_physical_memory_write(cplus_tx_ring_desc+4, &val, 4);
|
// cpu_physical_memory_write(cplus_tx_ring_desc+4, &val, 4);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue