file-posix: Fix shared locks on reopen commit
s->locked_shared_perm is the set of bits locked in the file, which is the inverse of the permissions actually shared. So we need to pass them as they are to raw_apply_lock_bytes() instead of inverting them again. Reported-by: Alberto Garcia <berto@igalia.com> Signed-off-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Alberto Garcia <berto@igalia.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
parent
9ad08c4456
commit
577a133988
|
@ -959,7 +959,7 @@ static void raw_reopen_commit(BDRVReopenState *state)
|
||||||
|
|
||||||
/* Copy locks to the new fd before closing the old one. */
|
/* Copy locks to the new fd before closing the old one. */
|
||||||
raw_apply_lock_bytes(NULL, rs->fd, s->locked_perm,
|
raw_apply_lock_bytes(NULL, rs->fd, s->locked_perm,
|
||||||
~s->locked_shared_perm, false, &local_err);
|
s->locked_shared_perm, false, &local_err);
|
||||||
if (local_err) {
|
if (local_err) {
|
||||||
/* shouldn't fail in a sane host, but report it just in case. */
|
/* shouldn't fail in a sane host, but report it just in case. */
|
||||||
error_report_err(local_err);
|
error_report_err(local_err);
|
||||||
|
|
Loading…
Reference in a new issue