memory-device: avoid overflows on very huge devices
Should not be a problem right now, but it could theoretically happen in the future. Signed-off-by: David Hildenbrand <david@redhat.com> Message-Id: <20181023152306.3123-7-david@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
parent
3e18dbbb13
commit
5e6aa26723
|
@ -85,7 +85,8 @@ static void memory_device_check_addable(MachineState *ms, uint64_t size,
|
||||||
|
|
||||||
/* will we exceed the total amount of memory specified */
|
/* will we exceed the total amount of memory specified */
|
||||||
memory_device_used_region_size(OBJECT(ms), &used_region_size);
|
memory_device_used_region_size(OBJECT(ms), &used_region_size);
|
||||||
if (used_region_size + size > ms->maxram_size - ms->ram_size) {
|
if (used_region_size + size < used_region_size ||
|
||||||
|
used_region_size + size > ms->maxram_size - ms->ram_size) {
|
||||||
error_setg(errp, "not enough space, currently 0x%" PRIx64
|
error_setg(errp, "not enough space, currently 0x%" PRIx64
|
||||||
" in use of total space for memory devices 0x" RAM_ADDR_FMT,
|
" in use of total space for memory devices 0x" RAM_ADDR_FMT,
|
||||||
used_region_size, ms->maxram_size - ms->ram_size);
|
used_region_size, ms->maxram_size - ms->ram_size);
|
||||||
|
|
Loading…
Reference in a new issue