haraldwolff/qemu-patch-raspberry4
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

SPARC: Fix Leon3 cache control

Browse source 
The "leon3_cache_control_int" (op_helper.c) function is called within leon3.c
which leads to segfault error with the global "env".

Now cache control is a CPU feature and everything is handled in op_helper.c.

Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
This commit is contained in:
Fabien Chouteau 2011-01-31 11:36:54 +01:00 committed by Blue Swirl
parent 2685d2961b
commit 60f356e86d
4 changed files with 23 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
hw/leon3.c
View file

@ -56,10 +56,9 @@ static void main_cpu_reset(void *opaque)
env->npc = s->entry + 4; env->npc = s->entry + 4;
} }
static void leon3_irq_ack(void *irq_manager, int intno) void leon3_irq_ack(void *irq_manager, int intno)
{ {
grlib_irqmp_ack((DeviceState *)irq_manager, intno); grlib_irqmp_ack((DeviceState *)irq_manager, intno);
leon3_cache_control_int();
} }
static void leon3_set_pil_in(void *opaque, uint32_t pil_in) static void leon3_set_pil_in(void *opaque, uint32_t pil_in)
@ -130,7 +129,7 @@ static void leon3_generic_hw_init(ram_addr_t ram_size,
/* Allocate IRQ manager */ /* Allocate IRQ manager */
grlib_irqmp_create(0x80000200, env, &cpu_irqs, MAX_PILS, &leon3_set_pil_in); grlib_irqmp_create(0x80000200, env, &cpu_irqs, MAX_PILS, &leon3_set_pil_in);
env->qemu_irq_ack = leon3_irq_ack; env->qemu_irq_ack = leon3_irq_manager;
/* Allocate RAM */ /* Allocate RAM */
if ((uint64_t)ram_size > (1UL << 30)) { if ((uint64_t)ram_size > (1UL << 30)) {

8
target-sparc/cpu.h
View file

@ -268,6 +268,8 @@ typedef struct sparc_def_t {
#define CPU_FEATURE_GL (1 << 13) #define CPU_FEATURE_GL (1 << 13)
#define CPU_FEATURE_TA0_SHUTDOWN (1 << 14) /* Shutdown on "ta 0x0" */ #define CPU_FEATURE_TA0_SHUTDOWN (1 << 14) /* Shutdown on "ta 0x0" */
#define CPU_FEATURE_ASR17 (1 << 15) #define CPU_FEATURE_ASR17 (1 << 15)
#define CPU_FEATURE_CACHE_CTRL (1 << 16)
#ifndef TARGET_SPARC64 #ifndef TARGET_SPARC64
#define CPU_DEFAULT_FEATURES (CPU_FEATURE_FLOAT | CPU_FEATURE_SWAP | \ #define CPU_DEFAULT_FEATURES (CPU_FEATURE_FLOAT | CPU_FEATURE_SWAP | \
CPU_FEATURE_MUL | CPU_FEATURE_DIV | \ CPU_FEATURE_MUL | CPU_FEATURE_DIV | \
@ -476,12 +478,14 @@ void cpu_put_cwp64(CPUState *env1, int cwp);
int cpu_cwp_inc(CPUState *env1, int cwp); int cpu_cwp_inc(CPUState *env1, int cwp);
int cpu_cwp_dec(CPUState *env1, int cwp); int cpu_cwp_dec(CPUState *env1, int cwp);
void cpu_set_cwp(CPUState *env1, int new_cwp); void cpu_set_cwp(CPUState *env1, int new_cwp);
void leon3_irq_manager(void *irq_manager, int intno);
void leon3_cache_control_int(void);
/* sun4m.c, sun4u.c */ /* sun4m.c, sun4u.c */
void cpu_check_irqs(CPUSPARCState *env); void cpu_check_irqs(CPUSPARCState *env);
/* leon3.c */
void leon3_irq_ack(void *irq_manager, int intno);
#if defined (TARGET_SPARC64) #if defined (TARGET_SPARC64)
static inline int compare_masked(uint64_t x, uint64_t y, uint64_t mask) static inline int compare_masked(uint64_t x, uint64_t y, uint64_t mask)

2
target-sparc/helper.c
View file

@ -1289,7 +1289,7 @@ static const sparc_def_t sparc_defs[] = {
.mmu_trcr_mask = 0xffffffff, .mmu_trcr_mask = 0xffffffff,
.nwindows = 8, .nwindows = 8,
.features = CPU_DEFAULT_FEATURES | CPU_FEATURE_TA0_SHUTDOWN | .features = CPU_DEFAULT_FEATURES | CPU_FEATURE_TA0_SHUTDOWN |
CPU_FEATURE_ASR17, CPU_FEATURE_ASR17 | CPU_FEATURE_CACHE_CTRL,
}, },
#endif #endif
}; };

18
target-sparc/op_helper.c
View file

@ -1653,7 +1653,7 @@ static void dump_asi(const char *txt, target_ulong addr, int asi, int size,
/* Leon3 cache control */ /* Leon3 cache control */
void leon3_cache_control_int(void) static void leon3_cache_control_int(void)
{ {
uint32_t state = 0; uint32_t state = 0;
@ -1741,11 +1741,17 @@ static uint64_t leon3_cache_control_ld(target_ulong addr, int size)
DPRINTF_CACHE_CONTROL("read unknown register %08x\n", addr); DPRINTF_CACHE_CONTROL("read unknown register %08x\n", addr);
break; break;
}; };
DPRINTF_CACHE_CONTROL("st addr:%08x, ret:%" PRIx64 ", size:%d\n", DPRINTF_CACHE_CONTROL("ld addr:%08x, ret:0x%" PRIx64 ", size:%d\n",
addr, ret, size); addr, ret, size);
return ret; return ret;
} }
void leon3_irq_manager(void *irq_manager, int intno)
{
leon3_irq_ack(irq_manager, intno);
leon3_cache_control_int();
}
uint64_t helper_ld_asi(target_ulong addr, int asi, int size, int sign) uint64_t helper_ld_asi(target_ulong addr, int asi, int size, int sign)
{ {
uint64_t ret = 0; uint64_t ret = 0;
@ -1760,7 +1766,9 @@ uint64_t helper_ld_asi(target_ulong addr, int asi, int size, int sign)
case 0x00: /* Leon3 Cache Control */ case 0x00: /* Leon3 Cache Control */
case 0x08: /* Leon3 Instruction Cache config */ case 0x08: /* Leon3 Instruction Cache config */
case 0x0C: /* Leon3 Date Cache config */ case 0x0C: /* Leon3 Date Cache config */
ret = leon3_cache_control_ld(addr, size); if (env->def->features & CPU_FEATURE_CACHE_CTRL) {
ret = leon3_cache_control_ld(addr, size);
}
break; break;
case 0x01c00a00: /* MXCC control register */ case 0x01c00a00: /* MXCC control register */
if (size == 8) if (size == 8)
@ -1994,7 +2002,9 @@ void helper_st_asi(target_ulong addr, uint64_t val, int asi, int size)
case 0x00: /* Leon3 Cache Control */ case 0x00: /* Leon3 Cache Control */
case 0x08: /* Leon3 Instruction Cache config */ case 0x08: /* Leon3 Instruction Cache config */
case 0x0C: /* Leon3 Date Cache config */ case 0x0C: /* Leon3 Date Cache config */
leon3_cache_control_st(addr, val, size); if (env->def->features & CPU_FEATURE_CACHE_CTRL) {
leon3_cache_control_st(addr, val, size);
}
break; break;
case 0x01c00000: /* MXCC stream data register 0 */ case 0x01c00000: /* MXCC stream data register 0 */