hmp/vnc: Fix info vnc list leak
We're iterating the list, and then freeing the iteration pointer rather than the list head. Fixes:stable-4.20a9667ecdb
("hmp: Update info vnc") Reported-by: Coverity (CID 1421932) Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Message-Id: <20200323120822.51266-1-dgilbert@redhat.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> (cherry picked from commitd4ff109373
) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
parent
5ff78dc9bc
commit
674d382225
|
@ -729,10 +729,11 @@ static void hmp_info_vnc_servers(Monitor *mon, VncServerInfo2List *server)
|
|||
|
||||
void hmp_info_vnc(Monitor *mon, const QDict *qdict)
|
||||
{
|
||||
VncInfo2List *info2l;
|
||||
VncInfo2List *info2l, *info2l_head;
|
||||
Error *err = NULL;
|
||||
|
||||
info2l = qmp_query_vnc_servers(&err);
|
||||
info2l_head = info2l;
|
||||
if (err) {
|
||||
hmp_handle_error(mon, &err);
|
||||
return;
|
||||
|
@ -761,7 +762,7 @@ void hmp_info_vnc(Monitor *mon, const QDict *qdict)
|
|||
info2l = info2l->next;
|
||||
}
|
||||
|
||||
qapi_free_VncInfo2List(info2l);
|
||||
qapi_free_VncInfo2List(info2l_head);
|
||||
|
||||
}
|
||||
#endif
|
||||
|
|
Loading…
Reference in New Issue