backup: Don't leak BackupBlockJob in error path
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
(cherry picked from commit 91ab688379
)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
stable-2.6
parent
45f4e4be09
commit
683c1c5ea5
|
@ -504,6 +504,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target,
|
|||
{
|
||||
int64_t len;
|
||||
BlockDriverInfo bdi;
|
||||
BackupBlockJob *job = NULL;
|
||||
int ret;
|
||||
|
||||
assert(bs);
|
||||
|
@ -568,8 +569,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target,
|
|||
goto error;
|
||||
}
|
||||
|
||||
BackupBlockJob *job = block_job_create(&backup_job_driver, bs, speed,
|
||||
cb, opaque, errp);
|
||||
job = block_job_create(&backup_job_driver, bs, speed, cb, opaque, errp);
|
||||
if (!job) {
|
||||
goto error;
|
||||
}
|
||||
|
@ -610,4 +610,7 @@ void backup_start(BlockDriverState *bs, BlockDriverState *target,
|
|||
if (sync_bitmap) {
|
||||
bdrv_reclaim_dirty_bitmap(bs, sync_bitmap, NULL);
|
||||
}
|
||||
if (job) {
|
||||
block_job_unref(&job->common);
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue