memory: cpu_physical_memory_set_dirty_range() always dirty all flags
So remove the flag argument and do it directly. After this change, there is nothing else using cpu_physical_memory_set_dirty_flags() so remove it. Signed-off-by: Juan Quintela <quintela@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Orit Wasserman <owasserm@redhat.com>
This commit is contained in:
parent
63995cebfa
commit
75218e7f2b
2
exec.c
2
exec.c
|
@ -1275,7 +1275,7 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host,
|
||||||
last_ram_offset() >> TARGET_PAGE_BITS);
|
last_ram_offset() >> TARGET_PAGE_BITS);
|
||||||
memset(ram_list.phys_dirty + (new_block->offset >> TARGET_PAGE_BITS),
|
memset(ram_list.phys_dirty + (new_block->offset >> TARGET_PAGE_BITS),
|
||||||
0, size >> TARGET_PAGE_BITS);
|
0, size >> TARGET_PAGE_BITS);
|
||||||
cpu_physical_memory_set_dirty_range(new_block->offset, size, 0xff);
|
cpu_physical_memory_set_dirty_range(new_block->offset, size);
|
||||||
|
|
||||||
qemu_ram_setup_dump(new_block->host, size);
|
qemu_ram_setup_dump(new_block->host, size);
|
||||||
qemu_madvise(new_block->host, size, QEMU_MADV_HUGEPAGE);
|
qemu_madvise(new_block->host, size, QEMU_MADV_HUGEPAGE);
|
||||||
|
|
|
@ -75,12 +75,6 @@ static inline int cpu_physical_memory_get_dirty(ram_addr_t start,
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline void cpu_physical_memory_set_dirty_flags(ram_addr_t addr,
|
|
||||||
int dirty_flags)
|
|
||||||
{
|
|
||||||
ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] |= dirty_flags;
|
|
||||||
}
|
|
||||||
|
|
||||||
static inline void cpu_physical_memory_set_dirty_flag(ram_addr_t addr,
|
static inline void cpu_physical_memory_set_dirty_flag(ram_addr_t addr,
|
||||||
int dirty_flag)
|
int dirty_flag)
|
||||||
{
|
{
|
||||||
|
@ -103,15 +97,14 @@ static inline int cpu_physical_memory_clear_dirty_flags(ram_addr_t addr,
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start,
|
static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start,
|
||||||
ram_addr_t length,
|
ram_addr_t length)
|
||||||
int dirty_flags)
|
|
||||||
{
|
{
|
||||||
ram_addr_t addr, end;
|
ram_addr_t addr, end;
|
||||||
|
|
||||||
end = TARGET_PAGE_ALIGN(start + length);
|
end = TARGET_PAGE_ALIGN(start + length);
|
||||||
start &= TARGET_PAGE_MASK;
|
start &= TARGET_PAGE_MASK;
|
||||||
for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
|
for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
|
||||||
cpu_physical_memory_set_dirty_flags(addr, dirty_flags);
|
cpu_physical_memory_set_dirty(addr);
|
||||||
}
|
}
|
||||||
xen_modified_memory(addr, length);
|
xen_modified_memory(addr, length);
|
||||||
}
|
}
|
||||||
|
|
2
memory.c
2
memory.c
|
@ -1182,7 +1182,7 @@ void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr,
|
||||||
hwaddr size)
|
hwaddr size)
|
||||||
{
|
{
|
||||||
assert(mr->terminates);
|
assert(mr->terminates);
|
||||||
cpu_physical_memory_set_dirty_range(mr->ram_addr + addr, size, -1);
|
cpu_physical_memory_set_dirty_range(mr->ram_addr + addr, size);
|
||||||
}
|
}
|
||||||
|
|
||||||
bool memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr,
|
bool memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr,
|
||||||
|
|
Loading…
Reference in a new issue