exec/memory: Extract address_space_set() from dma_memory_set()
dma_memory_set() does a DMA barrier, set the address space with a constant value. The constant value filling code is not specific to DMA and can be used for AddressSpace. Extract it as a new helper: address_space_set(). Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Laurent Vivier <laurent@vivier.eu> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> [lv: rebase] Signed-off-by: Laurent Vivier <laurent@vivier.eu> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: Peter Xu <peterx@redhat.com> Message-Id: <20220115203725.3834712-2-laurent@vivier.eu>staging
parent
5e0214cdee
commit
75f01c68b5
|
@ -2908,6 +2908,22 @@ address_space_write_cached(MemoryRegionCache *cache, hwaddr addr,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* address_space_set: Fill address space with a constant byte.
|
||||||
|
*
|
||||||
|
* Return a MemTxResult indicating whether the operation succeeded
|
||||||
|
* or failed (eg unassigned memory, device rejected the transaction,
|
||||||
|
* IOMMU fault).
|
||||||
|
*
|
||||||
|
* @as: #AddressSpace to be accessed
|
||||||
|
* @addr: address within that address space
|
||||||
|
* @c: constant byte to fill the memory
|
||||||
|
* @len: the number of bytes to fill with the constant byte
|
||||||
|
* @attrs: memory transaction attributes
|
||||||
|
*/
|
||||||
|
MemTxResult address_space_set(AddressSpace *as, hwaddr addr,
|
||||||
|
uint8_t c, hwaddr len, MemTxAttrs attrs);
|
||||||
|
|
||||||
#ifdef NEED_CPU_H
|
#ifdef NEED_CPU_H
|
||||||
/* enum device_endian to MemOp. */
|
/* enum device_endian to MemOp. */
|
||||||
static inline MemOp devend_memop(enum device_endian end)
|
static inline MemOp devend_memop(enum device_endian end)
|
||||||
|
|
|
@ -23,20 +23,7 @@ MemTxResult dma_memory_set(AddressSpace *as, dma_addr_t addr,
|
||||||
{
|
{
|
||||||
dma_barrier(as, DMA_DIRECTION_FROM_DEVICE);
|
dma_barrier(as, DMA_DIRECTION_FROM_DEVICE);
|
||||||
|
|
||||||
#define FILLBUF_SIZE 512
|
return address_space_set(as, addr, c, len, attrs);
|
||||||
uint8_t fillbuf[FILLBUF_SIZE];
|
|
||||||
int l;
|
|
||||||
MemTxResult error = MEMTX_OK;
|
|
||||||
|
|
||||||
memset(fillbuf, c, FILLBUF_SIZE);
|
|
||||||
while (len > 0) {
|
|
||||||
l = len < FILLBUF_SIZE ? len : FILLBUF_SIZE;
|
|
||||||
error |= address_space_write(as, addr, attrs, fillbuf, l);
|
|
||||||
len -= l;
|
|
||||||
addr += l;
|
|
||||||
}
|
|
||||||
|
|
||||||
return error;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void qemu_sglist_init(QEMUSGList *qsg, DeviceState *dev, int alloc_hint,
|
void qemu_sglist_init(QEMUSGList *qsg, DeviceState *dev, int alloc_hint,
|
||||||
|
|
|
@ -2927,6 +2927,25 @@ MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, MemTxAttrs attrs,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
MemTxResult address_space_set(AddressSpace *as, hwaddr addr,
|
||||||
|
uint8_t c, hwaddr len, MemTxAttrs attrs)
|
||||||
|
{
|
||||||
|
#define FILLBUF_SIZE 512
|
||||||
|
uint8_t fillbuf[FILLBUF_SIZE];
|
||||||
|
int l;
|
||||||
|
MemTxResult error = MEMTX_OK;
|
||||||
|
|
||||||
|
memset(fillbuf, c, FILLBUF_SIZE);
|
||||||
|
while (len > 0) {
|
||||||
|
l = len < FILLBUF_SIZE ? len : FILLBUF_SIZE;
|
||||||
|
error |= address_space_write(as, addr, attrs, fillbuf, l);
|
||||||
|
len -= l;
|
||||||
|
addr += l;
|
||||||
|
}
|
||||||
|
|
||||||
|
return error;
|
||||||
|
}
|
||||||
|
|
||||||
void cpu_physical_memory_rw(hwaddr addr, void *buf,
|
void cpu_physical_memory_rw(hwaddr addr, void *buf,
|
||||||
hwaddr len, bool is_write)
|
hwaddr len, bool is_write)
|
||||||
{
|
{
|
||||||
|
|
Loading…
Reference in New Issue