uhci: Raise interrupt when requested even for non active tds
According to the spec we must raise an interrupt when one is requested even for non active tds. Linux depends on this, for bulk transfers it runs an inactivity timer to work around a bug in early uhci revisions, when we take longer then 200 ms to process a packet, this timer goes of, and as part of the handling Linux then unlinks the qh, and relinks it after the frindex has increased by atleast 1, the problem is Linux only checks for the frindex increases on an interrupt, and we don't send that, causing the qh to go inactive for more then 32 frames, at which point we consider the packet cancelled. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
parent
5c16f76781
commit
883bca776d
|
@ -826,8 +826,16 @@ static int uhci_handle_td(UHCIState *s, uint32_t addr, UHCI_TD *td,
|
||||||
USBEndpoint *ep;
|
USBEndpoint *ep;
|
||||||
|
|
||||||
/* Is active ? */
|
/* Is active ? */
|
||||||
if (!(td->ctrl & TD_CTRL_ACTIVE))
|
if (!(td->ctrl & TD_CTRL_ACTIVE)) {
|
||||||
|
/*
|
||||||
|
* ehci11d spec page 22: "Even if the Active bit in the TD is already
|
||||||
|
* cleared when the TD is fetched ... an IOC interrupt is generated"
|
||||||
|
*/
|
||||||
|
if (td->ctrl & TD_CTRL_IOC) {
|
||||||
|
*int_mask |= 0x01;
|
||||||
|
}
|
||||||
return TD_RESULT_NEXT_QH;
|
return TD_RESULT_NEXT_QH;
|
||||||
|
}
|
||||||
|
|
||||||
async = uhci_async_find_td(s, addr, td);
|
async = uhci_async_find_td(s, addr, td);
|
||||||
if (async) {
|
if (async) {
|
||||||
|
|
Loading…
Reference in a new issue