hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention
The bounds check on the number of interrupt IDs is correct, but doesn't match our convention; change the variable name, initialize it to the 2^n value rather than (2^n)-1, and use >= instead of > in the comparison. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Message-id: 20220111171048.3545974-3-peter.maydell@linaro.org
This commit is contained in:
parent
8f809f6992
commit
905720f18d
|
@ -338,7 +338,7 @@ static bool process_mapti(GICv3ITSState *s, uint64_t value, uint32_t offset,
|
||||||
uint32_t devid, eventid;
|
uint32_t devid, eventid;
|
||||||
uint32_t pIntid = 0;
|
uint32_t pIntid = 0;
|
||||||
uint64_t num_eventids;
|
uint64_t num_eventids;
|
||||||
uint32_t max_Intid;
|
uint32_t num_intids;
|
||||||
bool dte_valid;
|
bool dte_valid;
|
||||||
MemTxResult res = MEMTX_OK;
|
MemTxResult res = MEMTX_OK;
|
||||||
uint16_t icid = 0;
|
uint16_t icid = 0;
|
||||||
|
@ -379,11 +379,11 @@ static bool process_mapti(GICv3ITSState *s, uint64_t value, uint32_t offset,
|
||||||
}
|
}
|
||||||
dte_valid = FIELD_EX64(dte, DTE, VALID);
|
dte_valid = FIELD_EX64(dte, DTE, VALID);
|
||||||
num_eventids = 1ULL << (FIELD_EX64(dte, DTE, SIZE) + 1);
|
num_eventids = 1ULL << (FIELD_EX64(dte, DTE, SIZE) + 1);
|
||||||
max_Intid = (1ULL << (GICD_TYPER_IDBITS + 1)) - 1;
|
num_intids = 1ULL << (GICD_TYPER_IDBITS + 1);
|
||||||
|
|
||||||
if ((devid >= s->dt.num_ids) || (icid >= s->ct.num_ids)
|
if ((devid >= s->dt.num_ids) || (icid >= s->ct.num_ids)
|
||||||
|| !dte_valid || (eventid >= num_eventids) ||
|
|| !dte_valid || (eventid >= num_eventids) ||
|
||||||
(((pIntid < GICV3_LPI_INTID_START) || (pIntid > max_Intid)) &&
|
(((pIntid < GICV3_LPI_INTID_START) || (pIntid >= num_intids)) &&
|
||||||
(pIntid != INTID_SPURIOUS))) {
|
(pIntid != INTID_SPURIOUS))) {
|
||||||
qemu_log_mask(LOG_GUEST_ERROR,
|
qemu_log_mask(LOG_GUEST_ERROR,
|
||||||
"%s: invalid command attributes "
|
"%s: invalid command attributes "
|
||||||
|
|
Loading…
Reference in a new issue