haraldwolff/qemu-patch-raspberry4
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

target-s390x: fix CONVERT TO BINARY (CVD, CVDY)

Browse source 
current_number being shift left by more than 32 bits, we can't use a
simple int. Similarly use an int64_t type for the input binary value,
to not get the -2^31 case wrong. Finally don't initialize shift to 4,
it's already done in the for loop.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Alexander Graf <agraf@suse.de>
This commit is contained in:
Aurelien Jarno 2015-06-25 21:16:58 +02:00 committed by Alexander Graf
parent c9c19b4932
commit 92f2b4e71e
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
target-s390x/int_helper.c
View file

@ -121,11 +121,12 @@ uint64_t HELPER(clz)(uint64_t v)
return clz64(v);
}
uint64_t HELPER(cvd)(int32_t bin)
uint64_t HELPER(cvd)(int32_t reg)
{
/* positive 0 */
uint64_t dec = 0x0c;
int shift = 4;
int64_t bin = reg;
int shift;
if (bin < 0) {
bin = -bin;
@ -133,9 +134,7 @@ uint64_t HELPER(cvd)(int32_t bin)
}
for (shift = 4; (shift < 64) && bin; shift += 4) {
int current_number = bin % 10;
dec |= (current_number) << shift;
dec |= (bin % 10) << shift;
bin /= 10;
}