From 9e84a4708f820976afd825745d4110dbaf58f431 Mon Sep 17 00:00:00 2001 From: Blue Swirl Date: Thu, 26 Aug 2010 18:04:18 +0000 Subject: [PATCH] etraxfs_eth: correct use of ! and & Combining bitwise AND and logical NOT is suspicious. Fixed by this Coccinelle script: // From http://article.gmane.org/gmane.linux.kernel/646367 @@ expression E1,E2; @@ ( !E1 & !E2 | - !E1 & E2 + !(E1 & E2) ) Acked-by: Edgar E. Iglesias Signed-off-by: Blue Swirl --- hw/etraxfs_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c index b897c9c167..ade96f14ac 100644 --- a/hw/etraxfs_eth.c +++ b/hw/etraxfs_eth.c @@ -464,7 +464,7 @@ static int eth_match_groupaddr(struct fs_eth *eth, const unsigned char *sa) /* First bit on the wire of a MAC address signals multicast or physical address. */ - if (!m_individual && !sa[0] & 1) + if (!m_individual && !(sa[0] & 1)) return 0; /* Calculate the hash index for the GA registers. */