haraldwolff/qemu-patch-raspberry4
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR)

Browse source 
Avoid flooding stdio by converting printf() calls to
qemu_log_mask(GUEST_ERROR), which are disabled by default.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-11-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Philippe Mathieu-Daudé 2020-05-26 08:22:48 +02:00 committed by Gerd Hoffmann
parent 7bbdf0f892
commit aa0fd16d00
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
hw/display/vmware_vga.c
View file

@ -26,6 +26,7 @@
#include "qemu/module.h" #include "qemu/module.h"
#include "qemu/units.h" #include "qemu/units.h"
#include "qapi/error.h" #include "qapi/error.h"
#include "qemu/log.h"
#include "hw/loader.h" #include "hw/loader.h"
#include "trace.h" #include "trace.h"
#include "ui/vnc.h" #include "ui/vnc.h"
@ -953,7 +954,8 @@ static uint32_t vmsvga_value_read(void *opaque, uint32_t address)
ret = s->scratch[s->index - SVGA_SCRATCH_BASE]; ret = s->scratch[s->index - SVGA_SCRATCH_BASE];
break; break;
} }
printf("%s: Bad register %02x\n", __func__, s->index); qemu_log_mask(LOG_GUEST_ERROR,
"%s: Bad register %02x\n", __func__, s->index);
ret = 0; ret = 0;
break; break;
} }
@ -1002,7 +1004,8 @@ static void vmsvga_value_write(void *opaque, uint32_t address, uint32_t value)
s->new_width = value; s->new_width = value;
s->invalidated = 1; s->invalidated = 1;
} else { } else {
printf("%s: Bad width: %i\n", __func__, value); qemu_log_mask(LOG_GUEST_ERROR,
"%s: Bad width: %i\n", __func__, value);
} }
break; break;
@ -1011,13 +1014,15 @@ static void vmsvga_value_write(void *opaque, uint32_t address, uint32_t value)
s->new_height = value; s->new_height = value;
s->invalidated = 1; s->invalidated = 1;
} else { } else {
printf("%s: Bad height: %i\n", __func__, value); qemu_log_mask(LOG_GUEST_ERROR,
"%s: Bad height: %i\n", __func__, value);
} }
break; break;
case SVGA_REG_BITS_PER_PIXEL: case SVGA_REG_BITS_PER_PIXEL:
if (value != 32) { if (value != 32) {
printf("%s: Bad bits per pixel: %i bits\n", __func__, value); qemu_log_mask(LOG_GUEST_ERROR,
"%s: Bad bits per pixel: %i bits\n", __func__, value);
s->config = 0; s->config = 0;
s->invalidated = 1; s->invalidated = 1;
} }
@ -1082,7 +1087,8 @@ static void vmsvga_value_write(void *opaque, uint32_t address, uint32_t value)
s->scratch[s->index - SVGA_SCRATCH_BASE] = value; s->scratch[s->index - SVGA_SCRATCH_BASE] = value;
break; break;
} }
printf("%s: Bad register %02x\n", __func__, s->index); qemu_log_mask(LOG_GUEST_ERROR,
"%s: Bad register %02x\n", __func__, s->index);
} }
} }