arm_gicv3: Add assert()s to tell Coverity that offsets are aligned
Coverity complains that the GICR_IPRIORITYR case in gicv3_readl() can overflow an array, because it doesn't know that the offsets passed to that function must be word aligned. Add some assert()s which hopefully tell Coverity that this isn't possible. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Message-id: 1468261372-17508-1-git-send-email-peter.maydell@linaro.org
This commit is contained in:
parent
ff9d3e9cd9
commit
acd8279621
|
@ -420,6 +420,8 @@ MemTxResult gicv3_redist_read(void *opaque, hwaddr offset, uint64_t *data,
|
||||||
MemTxResult r;
|
MemTxResult r;
|
||||||
int cpuidx;
|
int cpuidx;
|
||||||
|
|
||||||
|
assert((offset & (size - 1)) == 0);
|
||||||
|
|
||||||
/* This region covers all the redistributor pages; there are
|
/* This region covers all the redistributor pages; there are
|
||||||
* (for GICv3) two 64K pages per CPU. At the moment they are
|
* (for GICv3) two 64K pages per CPU. At the moment they are
|
||||||
* all contiguous (ie in this one region), though we might later
|
* all contiguous (ie in this one region), though we might later
|
||||||
|
@ -468,6 +470,8 @@ MemTxResult gicv3_redist_write(void *opaque, hwaddr offset, uint64_t data,
|
||||||
MemTxResult r;
|
MemTxResult r;
|
||||||
int cpuidx;
|
int cpuidx;
|
||||||
|
|
||||||
|
assert((offset & (size - 1)) == 0);
|
||||||
|
|
||||||
/* This region covers all the redistributor pages; there are
|
/* This region covers all the redistributor pages; there are
|
||||||
* (for GICv3) two 64K pages per CPU. At the moment they are
|
* (for GICv3) two 64K pages per CPU. At the moment they are
|
||||||
* all contiguous (ie in this one region), though we might later
|
* all contiguous (ie in this one region), though we might later
|
||||||
|
|
Loading…
Reference in a new issue