haraldwolff/qemu-patch-raspberry4
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

tests/qtest/vhost-user-blk-test: Check whether qemu-storage-daemon is available

Browse source 
The vhost-user-blk-test currently hangs if QTEST_QEMU_STORAGE_DAEMON_BINARY
points to a non-existing binary. Let's improve this situation by checking
for the availability of the binary first, so we can fail gracefully if
it is not accessible.

Message-Id: <20210811095949.133462-1-thuth@redhat.com>
Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
Tested-by: Alexander Bulekov <alxndr@bu.edu>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Thomas Huth 2021-08-11 11:59:49 +02:00
parent cc1838c25d
commit b063c290f3
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tests/qtest/vhost-user-blk-test.c
View file

@ -789,6 +789,14 @@ static const char *qtest_qemu_storage_daemon_binary(void)
exit(0);
}
/* If we've got a path to the binary, check whether we can access it */
if (strchr(qemu_storage_daemon_bin, '/') &&
access(qemu_storage_daemon_bin, X_OK) != 0) {
fprintf(stderr, "ERROR: '%s' is not accessible\n",
qemu_storage_daemon_bin);
exit(1);
}
return qemu_storage_daemon_bin;
}