hw/openrisc: Avoid using uninitialised variable 'entry'
clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized: hw/openrisc/openrisc_sim.c:69:9: error: variable 'entry' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized] if (kernel_filename && !qtest_enabled()) { ^~~~~~~~~~~~~~~ hw/openrisc/openrisc_sim.c:91:19: note: uninitialized use occurs here cpu->env.pc = entry; ^~~~~ Fix this by not attempting to change the CPU's starting PC unless we actually loaded a kernel. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Jia Liu <proljc@gmail.com>
This commit is contained in:
parent
ecfe10c9a6
commit
b6d9766ddf
|
@ -86,10 +86,9 @@ static void cpu_openrisc_load_kernel(ram_addr_t ram_size,
|
||||||
kernel_filename);
|
kernel_filename);
|
||||||
exit(1);
|
exit(1);
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
cpu->env.pc = entry;
|
cpu->env.pc = entry;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
static void openrisc_sim_init(QEMUMachineInitArgs *args)
|
static void openrisc_sim_init(QEMUMachineInitArgs *args)
|
||||||
{
|
{
|
||||||
|
|
Loading…
Reference in a new issue