dp8393x: Clean up endianness hacks
According to the datasheet, section 3.4.4, "in 32-bit mode ... the SONIC always writes long words". Therefore, use the same technique for the 'in_use' field that is used everywhere else, and write the full long word. Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Tested-by: Laurent Vivier <laurent@vivier.eu> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com> (cherry picked from commitstable-4.246ffee9ad4
) Conflicts: hw/net/dp8393x.c *roll in local dependencies onb7cbebf2b9
*drop functional dep. on19f7034773
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
parent
956e1b2d97
commit
bf3f12ac8c
|
@ -776,8 +776,6 @@ static ssize_t dp8393x_receive(NetClientState *nc, const uint8_t * buf,
|
|||
return -1;
|
||||
}
|
||||
|
||||
/* XXX: Check byte ordering */
|
||||
|
||||
/* Check for EOL */
|
||||
if (s->regs[SONIC_LLFA] & SONIC_DESC_EOL) {
|
||||
/* Are we still in resource exhaustion? */
|
||||
|
@ -847,15 +845,12 @@ static ssize_t dp8393x_receive(NetClientState *nc, const uint8_t * buf,
|
|||
/* EOL detected */
|
||||
s->regs[SONIC_ISR] |= SONIC_ISR_RDE;
|
||||
} else {
|
||||
/* Clear in_use, but it is always 16bit wide */
|
||||
int offset = dp8393x_crda(s) + sizeof(uint16_t) * 6 * width;
|
||||
if (s->big_endian && width == 2) {
|
||||
/* we need to adjust the offset of the 16bit field */
|
||||
offset += sizeof(uint16_t);
|
||||
}
|
||||
s->data[0] = 0;
|
||||
address_space_rw(&s->as, offset, MEMTXATTRS_UNSPECIFIED,
|
||||
(uint8_t *)s->data, sizeof(uint16_t), 1);
|
||||
/* Clear in_use */
|
||||
size = sizeof(uint16_t) * width;
|
||||
address = dp8393x_crda(s) + sizeof(uint16_t) * 6 * width;
|
||||
dp8393x_put(s, width, 0, 0);
|
||||
address_space_rw(&s->as, address, MEMTXATTRS_UNSPECIFIED,
|
||||
(uint8_t *)s->data, size, true);
|
||||
s->regs[SONIC_CRDA] = s->regs[SONIC_LLFA];
|
||||
s->regs[SONIC_ISR] |= SONIC_ISR_PKTRX;
|
||||
s->regs[SONIC_RSC] = (s->regs[SONIC_RSC] & 0xff00) | (((s->regs[SONIC_RSC] & 0x00ff) + 1) & 0x00ff);
|
||||
|
|
Loading…
Reference in New Issue