From c0465d1a1d4c9562cfa7e91f6c31ea1bce22052c Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Wed, 9 Nov 2011 17:42:23 +0000 Subject: [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes Add missing 'break' statements which would have meant that writing to an 8 bit NAND device was broken. Spotted by Coverity (see bug 887883). Signed-off-by: Peter Maydell Signed-off-by: Anthony Liguori --- hw/omap_gpmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c index 7fc82a2526..414f9f5c37 100644 --- a/hw/omap_gpmc.c +++ b/hw/omap_gpmc.c @@ -180,6 +180,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value, nand_setio(dev, (value >> 24) & 0xff); break; } + break; case OMAP_GPMC_16BIT: switch (size) { case 1: @@ -195,6 +196,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value, nand_setio(dev, (value >> 16) & 0xffff); break; } + break; } }