i386/acpi-build: more traditional _UID and _HID for PXB root buses
The ACPI specification permits the _HID and _UID objects to evaluate to strings. (See "6.1.5 _HID (Hardware ID)" and "6.1.12 _UID (Unique ID)" in the ACPI v6.0 spec.) With regard to related standards, the UEFI specification can also express a device address composed from string _HID and _UID identifiers, inside the Expanded ACPI Device Path Node. (See "9.3.3 ACPI Device Path", Table 49, in the UEFI v2.5 spec.) However, numeric (integer) contents for both _HID and _UID are more traditional. They are recommended by the UEFI spec for size reasons: [...] the ACPI Device Path node is smaller and should be used if possible to reduce the size of device paths that may potentially be stored in nonvolatile storage [...] External tools support them better (for example the --acpi_hid and --acpi_uid options of "efibootmgr" only take numeric identifiers). Finally, numeric _HID and _UID contents are existing practice in the QEMU source. This patch was tested with a Fedora 20 LiveCD and a preexistent Windows Server 2012 R2 guest. Using "acpidump" and "iasl" in the Fedora guest, we get, in the SSDT: > Scope (\_SB) > { > Device (PC04) > { > Name (_UID, 0x04) // _UID: Unique ID > Name (_HID, EisaId ("PNP0A03") /* PCI Bus */) // _HID: Hardware ID Cc: Marcel Apfelbaum <marcel@redhat.com> Cc: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
parent
21549a4642
commit
c96d9286a6
|
@ -944,9 +944,8 @@ build_ssdt(GArray *table_data, GArray *linker,
|
||||||
|
|
||||||
scope = aml_scope("\\_SB");
|
scope = aml_scope("\\_SB");
|
||||||
dev = aml_device("PC%.02X", bus_num);
|
dev = aml_device("PC%.02X", bus_num);
|
||||||
aml_append(dev,
|
aml_append(dev, aml_name_decl("_UID", aml_int(bus_num)));
|
||||||
aml_name_decl("_UID", aml_string("PC%.02X", bus_num)));
|
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A03")));
|
||||||
aml_append(dev, aml_name_decl("_HID", aml_string("PNP0A03")));
|
|
||||||
aml_append(dev, aml_name_decl("_BBN", aml_int(bus_num)));
|
aml_append(dev, aml_name_decl("_BBN", aml_int(bus_num)));
|
||||||
|
|
||||||
if (numa_node != NUMA_NODE_UNASSIGNED) {
|
if (numa_node != NUMA_NODE_UNASSIGNED) {
|
||||||
|
|
Loading…
Reference in a new issue