pvrdma: release device resources in case of an error
If during pvrdma device initialisation an error occurs, pvrdma_realize() does not release memory resources, leading to memory leakage. Reported-by: Li Qiang <liq3ea@163.com> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org> Message-Id: <20181212175817.815-1-ppandit@redhat.com> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
This commit is contained in:
parent
46b69a8824
commit
cce648613b
|
@ -573,7 +573,7 @@ static void pvrdma_shutdown_notifier(Notifier *n, void *opaque)
|
||||||
|
|
||||||
static void pvrdma_realize(PCIDevice *pdev, Error **errp)
|
static void pvrdma_realize(PCIDevice *pdev, Error **errp)
|
||||||
{
|
{
|
||||||
int rc;
|
int rc = 0;
|
||||||
PVRDMADev *dev = PVRDMA_DEV(pdev);
|
PVRDMADev *dev = PVRDMA_DEV(pdev);
|
||||||
Object *memdev_root;
|
Object *memdev_root;
|
||||||
bool ram_shared = false;
|
bool ram_shared = false;
|
||||||
|
@ -649,6 +649,7 @@ static void pvrdma_realize(PCIDevice *pdev, Error **errp)
|
||||||
|
|
||||||
out:
|
out:
|
||||||
if (rc) {
|
if (rc) {
|
||||||
|
pvrdma_fini(pdev);
|
||||||
error_append_hint(errp, "Device fail to load\n");
|
error_append_hint(errp, "Device fail to load\n");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue