s390x/protvirt: allow to IPL secure guests with -no-reboot
Right now, -no-reboot prevents secure guests from running. This is correct from an implementation point of view, as we have modeled the transition from non-secure to secure as a program directed IPL. From a user perspective, this is not the behavior of least surprise. We should implement the IPL into protected mode similar to the functions that we use for kdump/kexec. In other words, we do not stop here when -no-reboot is specified on the command line. Like function 0 or function 1, function 10 is not a classic reboot. For example, it can only be called once. Before calling it a second time, a real reboot/reset must happen in-between. So function code 10 is more or less a state transition reset, but not a "standard" reset or reboot. Fixes: 4d226deafc44 ("s390x: protvirt: Support unpack facility") Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> Reviewed-by: Janosch Frank <frankja@linux.ibm.com> Reviewed-by: David Hildenbrand <david@redhat.com> Acked-by: Viktor Mihajlovski <mihajlov@linux.ibm.com> Message-Id: <20200721103202.30610-1-borntraeger@de.ibm.com> [CH: tweaked description] Signed-off-by: Cornelia Huck <cohuck@redhat.com>
This commit is contained in:
parent
8ffa52c20d
commit
d1bb69db4c
|
@ -630,7 +630,8 @@ void s390_ipl_reset_request(CPUState *cs, enum s390_reset reset_type)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (reset_type == S390_RESET_MODIFIED_CLEAR ||
|
if (reset_type == S390_RESET_MODIFIED_CLEAR ||
|
||||||
reset_type == S390_RESET_LOAD_NORMAL) {
|
reset_type == S390_RESET_LOAD_NORMAL ||
|
||||||
|
reset_type == S390_RESET_PV) {
|
||||||
/* ignore -no-reboot, send no event */
|
/* ignore -no-reboot, send no event */
|
||||||
qemu_system_reset_request(SHUTDOWN_CAUSE_SUBSYSTEM_RESET);
|
qemu_system_reset_request(SHUTDOWN_CAUSE_SUBSYSTEM_RESET);
|
||||||
} else {
|
} else {
|
||||||
|
|
Loading…
Reference in a new issue