hw/mips/boston: Fix load_elf() error detection
load_elf() gives negative return in case of error, not zero.
Fixes: 10e3f30ff7
("hw/mips/boston: Allow loading elf kernel and dtb")
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20211130211729.7116-3-jiaxun.yang@flygoat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
This commit is contained in:
parent
24ade8c5de
commit
d77c462bf2
|
@ -777,14 +777,15 @@ static void boston_mach_init(MachineState *machine)
|
||||||
exit(1);
|
exit(1);
|
||||||
}
|
}
|
||||||
} else if (machine->kernel_filename) {
|
} else if (machine->kernel_filename) {
|
||||||
uint64_t kernel_entry, kernel_high, kernel_size;
|
uint64_t kernel_entry, kernel_high;
|
||||||
|
ssize_t kernel_size;
|
||||||
|
|
||||||
kernel_size = load_elf(machine->kernel_filename, NULL,
|
kernel_size = load_elf(machine->kernel_filename, NULL,
|
||||||
cpu_mips_kseg0_to_phys, NULL,
|
cpu_mips_kseg0_to_phys, NULL,
|
||||||
&kernel_entry, NULL, &kernel_high,
|
&kernel_entry, NULL, &kernel_high,
|
||||||
NULL, 0, EM_MIPS, 1, 0);
|
NULL, 0, EM_MIPS, 1, 0);
|
||||||
|
|
||||||
if (kernel_size) {
|
if (kernel_size > 0) {
|
||||||
int dt_size;
|
int dt_size;
|
||||||
g_autofree const void *dtb_file_data, *dtb_load_data;
|
g_autofree const void *dtb_file_data, *dtb_load_data;
|
||||||
hwaddr dtb_paddr = QEMU_ALIGN_UP(kernel_high, 64 * KiB);
|
hwaddr dtb_paddr = QEMU_ALIGN_UP(kernel_high, 64 * KiB);
|
||||||
|
|
Loading…
Reference in a new issue