ide: Reject invalid CHS geometry
drive_init() doesn't permit invalid CHS for if=ide, but that's worthless: we get it via if=none and -device. Signed-off-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
parent
7aa9c811ca
commit
dce9e92834
|
@ -2604,6 +2604,18 @@ int ide_init_drive(IDEState *s, BlockDriverState *bs,
|
||||||
s->bs = bs;
|
s->bs = bs;
|
||||||
bdrv_get_geometry(bs, &nb_sectors);
|
bdrv_get_geometry(bs, &nb_sectors);
|
||||||
bdrv_guess_geometry(bs, &cylinders, &heads, &secs);
|
bdrv_guess_geometry(bs, &cylinders, &heads, &secs);
|
||||||
|
if (cylinders < 1 || cylinders > 16383) {
|
||||||
|
error_report("cyls must be between 1 and 16383");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
if (heads < 1 || heads > 16) {
|
||||||
|
error_report("heads must be between 1 and 16");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
if (secs < 1 || secs > 63) {
|
||||||
|
error_report("secs must be between 1 and 63");
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
s->cylinders = cylinders;
|
s->cylinders = cylinders;
|
||||||
s->heads = heads;
|
s->heads = heads;
|
||||||
s->sectors = secs;
|
s->sectors = secs;
|
||||||
|
|
Loading…
Reference in a new issue