haraldwolff/qemu-patch-raspberry4
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

slirp: Remove superfluous memset() calls from the TFTP code

Browse source 
Commit fad7fb9ccd  ("Add IPv6 support to the TFTP code")
refactored some common code for preparing the mbuf into a new
function called tftp_prep_mbuf_data(). One part of this common
code is to do a "memset(m->m_data, 0, m->m_size);" for the related
buffer first. However, at two spots, the memset() was not removed
from the calling function, so it currently done twice in these code
paths. Thus let's delete these superfluous memsets in the calling
functions now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
This commit is contained in:
Thomas Huth 2016-06-27 12:41:36 +02:00 committed by Samuel Thibault
parent f7725df387
commit e5857062a6
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
slirp/tftp.c
View file

@ -208,8 +208,6 @@ static void tftp_send_error(struct tftp_session *spt,
goto out;
}
memset(m->m_data, 0, m->m_size);
tp = tftp_prep_mbuf_data(spt, m);
tp->tp_op = htons(TFTP_ERROR);
@ -237,8 +235,6 @@ static void tftp_send_next_block(struct tftp_session *spt,
return;
}
memset(m->m_data, 0, m->m_size);
tp = tftp_prep_mbuf_data(spt, m);
tp->tp_op = htons(TFTP_DATA);