test-string-input-visitor: Add more tests
Test that very big/small values are not accepted and that ranges with only one element work. Also test that ranges are ascending and cannot have more than 65536 elements. Rename expect4 to expect5, as we will be moving that to a separate ulist test after the rework. Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: David Hildenbrand <david@redhat.com> Message-Id: <20181121164421.20780-6-david@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
parent
e08a5241d3
commit
eac475410e
|
@ -121,7 +121,8 @@ static void test_visitor_in_intList(TestInputVisitorData *data,
|
|||
int64_t expect1[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 20 };
|
||||
int64_t expect2[] = { 32767, -32768, -32767 };
|
||||
int64_t expect3[] = { INT64_MAX, INT64_MIN };
|
||||
uint64_t expect4[] = { UINT64_MAX };
|
||||
int64_t expect4[] = { 1 };
|
||||
uint64_t expect5[] = { UINT64_MAX };
|
||||
Error *err = NULL;
|
||||
int64List *res = NULL;
|
||||
int64List *tail;
|
||||
|
@ -140,8 +141,44 @@ static void test_visitor_in_intList(TestInputVisitorData *data,
|
|||
"-9223372036854775808,9223372036854775807");
|
||||
check_ilist(v, expect3, ARRAY_SIZE(expect3));
|
||||
|
||||
v = visitor_input_test_init(data, "1-1");
|
||||
check_ilist(v, expect4, ARRAY_SIZE(expect4));
|
||||
|
||||
v = visitor_input_test_init(data, "18446744073709551615");
|
||||
check_ulist(v, expect4, ARRAY_SIZE(expect4));
|
||||
check_ulist(v, expect5, ARRAY_SIZE(expect5));
|
||||
|
||||
/* Value too large */
|
||||
|
||||
v = visitor_input_test_init(data, "9223372036854775808");
|
||||
visit_type_int64List(v, NULL, &res, &err);
|
||||
error_free_or_abort(&err);
|
||||
g_assert(!res);
|
||||
|
||||
/* Value too small */
|
||||
|
||||
v = visitor_input_test_init(data, "-9223372036854775809");
|
||||
visit_type_int64List(v, NULL, &res, &err);
|
||||
error_free_or_abort(&err);
|
||||
g_assert(!res);
|
||||
|
||||
/* Range not ascending */
|
||||
|
||||
v = visitor_input_test_init(data, "3-1");
|
||||
visit_type_int64List(v, NULL, &res, &err);
|
||||
error_free_or_abort(&err);
|
||||
g_assert(!res);
|
||||
|
||||
v = visitor_input_test_init(data, "9223372036854775807-0");
|
||||
visit_type_int64List(v, NULL, &res, &err);
|
||||
error_free_or_abort(&err);
|
||||
g_assert(!res);
|
||||
|
||||
/* Range too big (65536 is the limit against DOS attacks) */
|
||||
|
||||
v = visitor_input_test_init(data, "0-65536");
|
||||
visit_type_int64List(v, NULL, &res, &err);
|
||||
error_free_or_abort(&err);
|
||||
g_assert(!res);
|
||||
|
||||
/* Empty list */
|
||||
|
||||
|
|
Loading…
Reference in a new issue