target/arm/monitor: query-cpu-model-expansion crashed qemu when using machine type none
Commitstable-4.2e19afd5667
mentioned that target-arm only supports queryable cpu models 'max', 'host', and the current type when KVM is in use. The logic works well until using machine type none. For machine type none, cpu_type will be null if cpu option is not set by command line, strlen(cpu_type) will terminate process. So We add a check above it. This won't affect i386 and s390x since they do not use current_cpu. Signed-off-by: Liang Yan <lyan@suse.com> Message-id: 20200203134251.12986-1-lyan@suse.com Reviewed-by: Andrew Jones <drjones@redhat.com> Tested-by: Andrew Jones <drjones@redhat.com> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> (cherry picked from commit0999a4ba87
) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
parent
8952da32c3
commit
ee9f37f3e5
|
@ -136,17 +136,20 @@ CpuModelExpansionInfo *qmp_query_cpu_model_expansion(CpuModelExpansionType type,
|
|||
}
|
||||
|
||||
if (kvm_enabled()) {
|
||||
const char *cpu_type = current_machine->cpu_type;
|
||||
int len = strlen(cpu_type) - strlen(ARM_CPU_TYPE_SUFFIX);
|
||||
bool supported = false;
|
||||
|
||||
if (!strcmp(model->name, "host") || !strcmp(model->name, "max")) {
|
||||
/* These are kvmarm's recommended cpu types */
|
||||
supported = true;
|
||||
} else if (strlen(model->name) == len &&
|
||||
!strncmp(model->name, cpu_type, len)) {
|
||||
/* KVM is enabled and we're using this type, so it works. */
|
||||
supported = true;
|
||||
} else if (current_machine->cpu_type) {
|
||||
const char *cpu_type = current_machine->cpu_type;
|
||||
int len = strlen(cpu_type) - strlen(ARM_CPU_TYPE_SUFFIX);
|
||||
|
||||
if (strlen(model->name) == len &&
|
||||
!strncmp(model->name, cpu_type, len)) {
|
||||
/* KVM is enabled and we're using this type, so it works. */
|
||||
supported = true;
|
||||
}
|
||||
}
|
||||
if (!supported) {
|
||||
error_setg(errp, "We cannot guarantee the CPU type '%s' works "
|
||||
|
|
Loading…
Reference in New Issue