xhci: Fix possible side effect from assert()
A static analysis tool called BEAM detected possible side effect from assert() calling a helper which may change an XHCI ring after every call. This moves xhci_ring_fetch() out of assert() so it will be called with and without enabled debug. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> Message-id: 1468812548-31868-1-git-send-email-aik@ozlabs.ru Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
parent
5d3217340a
commit
f81bb347ef
|
@ -2201,7 +2201,9 @@ static void xhci_kick_ep(XHCIState *xhci, unsigned int slotid,
|
||||||
xfer->trb_count = length;
|
xfer->trb_count = length;
|
||||||
|
|
||||||
for (i = 0; i < length; i++) {
|
for (i = 0; i < length; i++) {
|
||||||
assert(xhci_ring_fetch(xhci, ring, &xfer->trbs[i], NULL));
|
TRBType type;
|
||||||
|
type = xhci_ring_fetch(xhci, ring, &xfer->trbs[i], NULL);
|
||||||
|
assert(type);
|
||||||
}
|
}
|
||||||
xfer->streamid = streamid;
|
xfer->streamid = streamid;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue