haraldwolff/qemu-patch-raspberry4
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

libqtest: Clean up how we read device_del messages

Browse source 
qtest_qmp_device_del() still uses the qmp("") hack to receive a
message, even though we have qmp_receive() since commit 66e0c7b187.
Put it to use.

Bonus: gets rid of empty format strings.  A step towards compile-time
format string checking without triggering -Wformat-zero-length.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180806065344.7103-3-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2018-08-06 08:53:23 +02:00
parent 4277f1ebd9
commit f94648fe3d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/libqtest.c
View file

@ -1090,7 +1090,7 @@ void qtest_qmp_device_del(const char *id)
g_assert(response1);
g_assert(!qdict_haskey(response1, "error"));
response2 = qmp("");
response2 = qmp_receive();
g_assert(response2);
g_assert(!qdict_haskey(response2, "error"));