hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn
The check "liobn & 0xFFFFFFFF00000000ULL" in spapr_tce_find_by_liobn() is completely useless since liobn is only declared as an uint32_t parameter. Fix this by using target_ulong instead (this is what most of the callers of this function are using, too). Signed-off-by: Thomas Huth <thuth@redhat.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Alexander Graf <agraf@suse.de>
This commit is contained in:
parent
dea1b3ce75
commit
f9ce8e0aa3
|
@ -41,7 +41,7 @@ enum sPAPRTCEAccess {
|
||||||
|
|
||||||
static QLIST_HEAD(spapr_tce_tables, sPAPRTCETable) spapr_tce_tables;
|
static QLIST_HEAD(spapr_tce_tables, sPAPRTCETable) spapr_tce_tables;
|
||||||
|
|
||||||
sPAPRTCETable *spapr_tce_find_by_liobn(uint32_t liobn)
|
sPAPRTCETable *spapr_tce_find_by_liobn(target_ulong liobn)
|
||||||
{
|
{
|
||||||
sPAPRTCETable *tcet;
|
sPAPRTCETable *tcet;
|
||||||
|
|
||||||
|
@ -52,7 +52,7 @@ sPAPRTCETable *spapr_tce_find_by_liobn(uint32_t liobn)
|
||||||
}
|
}
|
||||||
|
|
||||||
QLIST_FOREACH(tcet, &spapr_tce_tables, list) {
|
QLIST_FOREACH(tcet, &spapr_tce_tables, list) {
|
||||||
if (tcet->liobn == liobn) {
|
if (tcet->liobn == (uint32_t)liobn) {
|
||||||
return tcet;
|
return tcet;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -511,7 +511,7 @@ struct sPAPRTCETable {
|
||||||
QLIST_ENTRY(sPAPRTCETable) list;
|
QLIST_ENTRY(sPAPRTCETable) list;
|
||||||
};
|
};
|
||||||
|
|
||||||
sPAPRTCETable *spapr_tce_find_by_liobn(uint32_t liobn);
|
sPAPRTCETable *spapr_tce_find_by_liobn(target_ulong liobn);
|
||||||
void spapr_events_init(sPAPREnvironment *spapr);
|
void spapr_events_init(sPAPREnvironment *spapr);
|
||||||
void spapr_events_fdt_skel(void *fdt, uint32_t epow_irq);
|
void spapr_events_fdt_skel(void *fdt, uint32_t epow_irq);
|
||||||
int spapr_h_cas_compose_response(target_ulong addr, target_ulong size);
|
int spapr_h_cas_compose_response(target_ulong addr, target_ulong size);
|
||||||
|
|
Loading…
Reference in a new issue