From fd5d23babf9838c1b099a9e8020e778aac0ebb4d Mon Sep 17 00:00:00 2001 From: Iwona Kotlarska Date: Thu, 30 Mar 2017 07:09:24 +0200 Subject: [PATCH] hmp: fix "dump-quest-memory" segfault Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and executing "dump-guest-memory /dev/null 0 8192" results in segfault. Fix by checking if we have CPU. Signed-off-by: Iwona Kotlarska Message-Id: <20170330050924.22134-1-iwona260909@gmail.com> Reviewed-by: Stefan Hajnoczi Reviewed-by: Marcel Apfelbaum Reviewed-by: Eduardo Habkost Signed-off-by: Dr. David Alan Gilbert Fixed up title --- target/i386/arch_dump.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c index 5a2e4be5d0..fe0aa36932 100644 --- a/target/i386/arch_dump.c +++ b/target/i386/arch_dump.c @@ -391,8 +391,7 @@ int cpu_get_dump_info(ArchDumpInfo *info, #ifdef TARGET_X86_64 X86CPU *first_x86_cpu = X86_CPU(first_cpu); - - lma = !!(first_x86_cpu->env.hflags & HF_LMA_MASK); + lma = first_cpu && (first_x86_cpu->env.hflags & HF_LMA_MASK); #endif if (lma) {