On oss-fuzz, we must use the LIB_FUZZING_ENGINE and CFLAGS environment
variables, rather than -fsanitize=fuzzer. With this change, when
LIB_FUZZING_ENGINE is set, the --enable-fuzzing configure option will
use that environment variable during the linking stage, rather than
-fsanitize=fuzzer
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20200902173652.307222-3-alxndr@bu.edu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
With this change, the fuzzer-linker script should be specified outside
any --start-group/--end-group pairs. We need this on oss-fuzz, where
partially applying the linker-script results in a linker failure
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20200902173652.307222-2-alxndr@bu.edu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Prior to this change,
readelf -d build/out/qemu/qemu-fuzz-i386-target-virtio-net-slirp
...
0x000000000000000f (RPATH) Library rpath: ['$$ORIGIN/lib':$ORIGIN/migration:$ORIGIN/]
As of 1a4db552d8 ("ninjatool: quote dollars in variables"), we don't
need to manually double the dollars. Also, remove the single-quotes as
they are copied into the rpath.
After this change:
0x000000000000000f (RPATH) Library rpath: [$ORIGIN/lib:$ORIGIN/migration:$ORIGIN/]
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20200902142657.112879-3-alxndr@bu.edu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Update the dtc submodule in configure already and symlink dtc after
git submodule update, because on win32 symlinks to non-existing folders
are forbidden.
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Message-Id: <20200902170054.810-2-luoyonggang@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
All Meson executables should specify their dependencies explicitly, either
directly or indirectly via declare_dependency. Makefiles instead did
not propagate dependencies correctly from static libraries, for example.
Therefore, flags for dependencies need not be included in QEMU_CFLAGS.
LIBS is not used at all, so drop that one as well.
In a few cases the dependencies were not yet specified, so add them.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The opengl compilation flags were added to QEMU_CFLAGS. We do not
want them to be added to all compilation commands, so export them
also via OPENGL_CFLAGS rather than via QEMU_CFLAGS.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The glib compilation flags were added to QEMU_CFLAGS. While we still
want them to be added to all compilation commands (at least for now),
do that via GLIB_CFLAGS rather than via QEMU_CFLAGS. This shows that
glib is a special case and makes it clearer that QEMU_CFLAGS is only
about compiler commands and not dependencies.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Makefile.objs, the .d files and various CONFIG_* symbols are not
used anymore by the Make side of the build; they are only processed
by Meson. We can delete them.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
There is no need anymore to produce config-all-devices.mak, compute
the resulting dictionary directly instead of going through grepy.sh.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The $pwd_is_source_path variable is never "y", since
configure re-executes itself from a build directory.
Remove code that will never run.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Use meson benchmark() for them, adjust mtest2make.py for that.
A new target "make bench" can be used to run all benchmarks.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200828110734.1638685-14-marcandre.lureau@redhat.com>
[Rewrite mtest2make part. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
As this makes the TAP output invalid. Use g_test_message().
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200828110734.1638685-13-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
It was covered already in commit d3ca592b3c ("meson: convert check-block")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200828110734.1638685-9-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Since there is not minimum version specified, and it's a test-only
dependency, it's fair to depend on a version that ships with a .pc I
suppose.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200828110734.1638685-8-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
UEFI on ia32 never really took off. Basically the BIOS -> UEFI shift
came too late, x64 was widespread already, so vendors went from BIOS
straight to UEFI on x64.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
master snapshot, most recent commit from Aug 23th
shortlog
========
Andrew Grasso (1):
[intel] Add INTEL_NO_PHY_RST for I218LM
Ben Bleything (1):
[intel] Set INTEL_NO_PHY_RST on i218v
Bobby Lockwood (1):
[libgcc] Change __divmoddi4 from int64 [unknown] to int64_t
Bruce Rogers (1):
[build] Be explicit about -fcommon compiler directive
Christian Nilsson (1):
[intel] Add PCI ID for I219-V and -LM 6 to 9
Daniel Johnson (1):
[deflate] Fix typo in comment describing length codes
David Decotigny (2):
[pcbios] Fix "out of memory" detection when expanding bottom area
[pcbios] Take alignment into account when checking for available space
Dentcho Ludmilov Bankov (1):
[comboot] Fix stack pointer retrieval after COM32 binary returns
Ignat Korchagin (3):
[snp] Try promiscuous multicast receive filter if the regular one fails
[snp] Set EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST bit as per UEFI spec
[efi] Check the status code from AllocatePool()
Joe Groocock (1):
[cmdline] Add "--timeout" parameter to "ifconf" command
Joseph Wong (1):
[bnxt] Add driver support for Broadcom NetXtreme-E Adapters
LaDerrick H (1):
[sfc] Add PCI ID for Solarflare SFC9120 and Solarflare SFC9140
Michael Brown (105):
[init] Show startup and shutdown function names in debug messages
[efi] Blacklist the Dell Ip4ConfigDxe driver
[tls] Support stateful session resumption
[tls] Fix incorrectly duplicated error number
[tls] Support stateless session resumption
[crypto] Use x509_name() in validator debug messages
[tls] Display cross-certificate and OCSP status messages
[tls] Display validator messages only while validation is in progress
[tcp] Display "connecting" status until connection is established
[ocsp] Accept response certID with missing hashAlgorithm parameters
[pci] Add support for PCI MSI-X interrupts
[vlan] Provide vlan_netdev_rx() and vlan_netdev_rx_err()
[intelxl] Use VLAN tag in receive descriptor if present
[intelxl] Allow for virtual function admin queue register maps
[intelxl] Use one admin queue buffer per admin queue descriptor
[intelxl] Allow admin queues to be reinitialised
[intelxl] Allow admin cookie to hold extended opcode and return code
[intelxl] Provide a mechanism for handling "send to VF" events
[intelxl] Use 32-byte receive descriptors
[intelxl] Allow for arbitrary placement of ring tail registers
[intelxl] Split out ring creation from context programming
[intelxl] Allow for arbitrary placement of interrupt control register
[intelxl] Expose functions required by virtual function driver
[intelxl] Choose to operate in non-PXE mode
[intelxl] Add driver for Intel 40 Gigabit Ethernet NIC virtual functions
[build] Fix use of inline assembly on GCC 8 ARM64 builds
[arm] Provide dummy implementations for {in,out}[s]{b,w,l}
[efi] Return only registered EFI devices from efidev_parent()
[fdt] Add ability to parse a MAC address from a flattened device tree
[efi] Register a device tree if provided by the platform firmware
[smsc95xx] Fetch MAC from device tree for Raspberry Pi
[build] Add named configuration for Raspberry Pi
[smscusb] Fetch MAC from device tree for Raspberry Pi Model B+
[build] Do not apply WORKAROUND_CFLAGS for host compiler
[build] Move predefined all-drivers build shortcut to Makefile
[build] Add predefined shortcut for Raspberry Pi builds
[process] Add PROC_INIT() for initialising static processes
[peerdist] Start block download timers from within opener methods
[peerdist] Limit number of concurrent raw block downloads
[tls] Add missing call to tls_tx_resume() when restarting negotiation
[crypto] Drag in configured digestInfo prefixes for any use of RSA
[crypto] Profile the various stages of modular multiplication
[coverity] Override assumptions about wcrtomb() and hmac_init()
[ethernet] Avoid false positive Coverity warning
[golan] Fix address-of-pointer bug for multicast attach/detach
[efi] Report failed control transfers as expected by the USB core
[efi] Do not attempt EFI_USB_IO_PROTOCOL transfers during shutdown
[lan78xx] Always enable automatic speed and duplex detection
[peerdist] Allow PeerDist to be globally enabled or disabled
[peerdist] Allow for the use of a hosted cache server
[build] Construct full version number automatically from git revision
[travis] Ensure that most recent tag is always available
[tftp] Eliminate unnecessary variable-length stack allocation
[infiniband] Eliminate variable-length stack allocation
[slam] Eliminate variable-length stack allocation
[slam] Allow for the possibility of IPv6 multicast addresses
[settings] Eliminate variable-length stack allocation
[iscsi] Eliminate variable-length stack allocations in CHAP handlers
[iscsi] Eliminate variable-length stack allocation in URI parsing
[bios] Define macros for constructing partition table entries
[int13con] Create log partition only when CONSOLE_INT13 is enabled
[efi] Disambiguate errors returned by ConnectController
[png] Fix potential integer overflow
[efi] Work around UEFI specification bug in LoadImage
[efi] Work around UEFI specification bug in LoadImage for SAN boot
[uri] Avoid appearing to access final byte of a potentially empty string
[efi] Attempt to connect our driver directly if ConnectController fails
[tls] Allow a minimum TLS protocol version to be specified
[tls] Default to supporting only TLSv1.1 or above
[crypto] Allow algorithms to be included without being OID-identifiable
[crypto] Ensure that test code drags in required ASN.1 object identifiers
[crypto] Disable MD5 as an OID-identifiable algorithm by default
[snp] Retry initialisation if link is reported as down
[util] Treat empty integer strings as invalid
[parseopt] Treat empty integer strings in user input as invalid
[efi] Enable stack protection where possible
[ocsp] Accept SHA1 certID responses even if SHA1 is not enabled
[intel] Avoid spurious compiler warning on GCC 10
[golan] Add explicit type casts for nodnic_queue_pair_type
[build] Disable position-independent code for ARM64 EFI builds
[efi] Detect and disable seriously broken EFI_RNG_PROTOCOL implementations
[efi] Raise TPL during driver entry point
[axge] Handle non-gigabit link speeds
[usb] Clear device endpoint halt before resetting host endpoint
[usb] Add missing usb_recycle() for completed hub interrupt transfers
[usb] Do not attempt to disable USB3 hub ports
[xhci] Set link state to RxDetect after disabling USB3 root hub port
[usb] Avoid unnecessary calls to usb_hub_set_drvdata()
[xhci] Increase link state settling delay to 100ms
[axge] Reapply USB device configuration when opening network device
[usb] Leave port enabled after a failed device registration
[crypto] Avoid temporarily setting direction flag in bigint_is_geq()
[libc] Provide an unoptimised generic_memcpy_reverse()
[efi] Avoid setting direction flag on EFI platforms
[libc] Add bit-rotation functions for unsigned long values
[efi] Distribute available entropy within stack cookie
[efi] Ensure NUL byte is at lowest address within stack cookie
[efi] Claim SNP devices early in efi_download_start()
[xfer] Remove address family from definition of a socket opener
[dns] Use all configured DNS servers
[wpa] Fix erroneous debug message in wpa_derive_ptk
[efi] Match EDK2 numbering for USB ports
[efi] Use device path to locate filesystem from which we were loaded
[efi] Attempt NII initialisation both with and without cable detection
[build] Fix building on older versions of gcc
Michael J. Bazzinotti (1):
[libc] Fix memcmp() to return proper values
Mohammed (1):
[golan] Add various new PCI device IDs
Rob Taglang (1):
[intelx] Added PCI_ROM entry for Intel x553/x557-AT and x553 (SFP+) NICs
Tobias Kortkamp (1):
[build] Fix a GNUism that FreeBSD's sed(1) cannot deal with
Valentine Barshak (2):
[build] Fix "'%s' directive argument is null" error
[build] Workaround compilation error with gcc 9.1
bit (1):
[build] Fix default target in sdsk image
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This is required by test-qht-par unit test.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200828110734.1638685-5-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Rename the variable to be more explicit. A further clean-up patch will
move the actual to dependency check to meson entirely.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200828110734.1638685-4-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
- builds QAPI builtins types/visitor to fix a linking issue with
unresolved symbols in the static library.
- work around a meson limitation on generated file output directories.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200828110734.1638685-2-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Add genh to the sources to avoid race conditions between QAPI
file generation and libqos compilation.
Make the name_suffix .fa for consistency with other link_whole
static libraries and to work around a Meson issue where
lots of linker flags are placed between -Wl,--start-group and
-Wl,--end-group and this breaks the fork-fuzz.ld linker script.
Reported-by: Claudio Fontana <cfontana@suse.de>
Reported-by: Alexander Bulekov <alxndr@bu.edu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Numbering files according to rules causes confusion, because
CUSTOM_COMMAND3.stamp from a previous build might represent
completely different targets after Makefile.ninja is regenerated.
As a result, the new targets are not rebuilt and compilation
fails.
Use the targets to build a SHA1 hash; the chances for collision
are one in 2^24 even with a 12-character prefix of the hash.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
On msys2, paths such as -L/e/path/to/qemu are not recognized by
the linker. Fortunately we do not need absolute paths at all in a
non-recursive build system.
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Meson automatically adds "-undefined dynamic_lookup" to
shared_module build targets; b_lundef is only needed for
executables. Therefore, we can remove this option.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Whenever a test appears in multiple suites, the rules generated
by mtest2make are currently running it twice. Instead, after
this patch we generate a phony target for each test and we have
a generic "run-tests" target depend on all the tests that were
chosen on the command line. Tests that appear in multiple suites
will be added to the prerequisites just once.
This has other advantages: it removes the handling of -k and
it increases parallelism.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The softfloat tests are quite noisy; before the Meson conversion
they buffered the output in a file and emitted the output only
if the test failed. Tweak mtest2make.py so that the courtesy
is extended to all non-TAP tests.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Pass the working directory and test command in separate macro arguments,
so that we will be able to insert a test driver in the next patch.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Pass the environment and test command in separate macro arguments,
so that we will be able to insert a test driver in the next patch.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
check-block has its own test harness, unlike every other test. If
we capture its output, as is in general nicer to do without V=1,
there will be no sign of progress. So for lack of a better option
just move the invocation of the test back to Makefile rules.
As a side effect, this will also fix "make check" in --disable-tools
builds, as they were trying to run qemu-iotests without having
made qemu-img before.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The current implementation of h_home_node_associativity hard codes
the values of associativity domains of the vcpus. Let's make
it consider the values already initialized in spapr->numa_assoc_array,
via the spapr_numa_get_vcpu_assoc() helper.
We want to set it and forget it, and for that we also need to
assert that we don't overflow the registers of the hypercall.
>From R4 to R9 we can squeeze in 12 associativity domains for
vcpus, so let's assert that VCPU_ASSOC_SIZE -1 isn't greater
than that.
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20200904172422.617460-4-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
The work to be done in h_home_node_associativity() intersects
with what is already done in spapr_numa_fixup_cpu_dt(). This
patch creates a new helper, spapr_numa_get_vcpu_assoc(), to
be used for both spapr_numa_fixup_cpu_dt() and
h_home_node_associativity().
While we're at it, use memcpy() instead of loop assignment
to created the returned array.
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20200904172422.617460-3-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
The implementation of this hypercall will be modified to use
spapr->numa_assoc_arrays input. Moving it to spapr_numa.c makes
make more sense.
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20200904172422.617460-2-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
The NVLink2 GPUs works like a regular NUMA node with its
own associativity values, regardless of user input.
This can be handled inside spapr_numa_associativity_init(),
initializing NVGPU_MAX_NUM associativity arrays that can
be used by the GPUs.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20200903220639.563090-5-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
In a similar fashion as the previous patch, let's move the
handling of ibm,associativity-lookup-arrays from spapr.c to
spapr_numa.c. A spapr_numa_write_assoc_lookup_arrays() helper was
created, and spapr_dt_dynamic_reconfiguration_memory() can now
use it to advertise the lookup-arrays.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20200903220639.563090-4-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
