00e30f05de
Drop write notifiers and use filter node instead. = Changes = 1. Add filter-node-name argument for backup qmp api. We have to do it in this commit, as 257 needs to be fixed. 2. There are no more write notifiers here, so is_write_notifier parameter is dropped from block-copy paths. 3. To sync with in-flight requests at job finish we now have drained removing of the filter, we don't need rw-lock. 4. Block-copy is now using BdrvChildren instead of BlockBackends 5. As backup-top owns these children, we also move block-copy state into backup-top's ownership. = Iotest changes = 56: op-blocker doesn't shoot now, as we set it on source, but then check on filter, when trying to start second backup. To keep the test we instead can catch another collision: both jobs will get 'drive0' job-id, as job-id parameter is unspecified. To prevent interleaving with file-posix locks (as they are dependent on config) let's use another target for second backup. Also, it's obvious now that we'd like to drop this op-blocker at all and add a test-case for two backups from one node (to different destinations) actually works. But not in these series. 141: Output changed: prepatch, "Node is in use" comes from bdrv_has_blk check inside qmp_blockdev_del. But we've dropped block-copy blk objects, so no more blk objects on source bs (job blk is on backup-top filter bs). New message is from op-blocker, which is the next check in qmp_blockdev_add. 257: The test wants to emulate guest write during backup. They should go to filter node, not to original source node, of course. Therefore we need to specify filter node name and use it. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Message-id: 20191001131409.14202-6-vsementsov@virtuozzo.com Reviewed-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Max Reitz <mreitz@redhat.com>
94 lines
3.1 KiB
C
94 lines
3.1 KiB
C
/*
|
||
* block_copy API
|
||
*
|
||
* Copyright (C) 2013 Proxmox Server Solutions
|
||
* Copyright (c) 2019 Virtuozzo International GmbH.
|
||
*
|
||
* Authors:
|
||
* Dietmar Maurer (dietmar@proxmox.com)
|
||
* Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
||
*
|
||
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
||
* See the COPYING file in the top-level directory.
|
||
*/
|
||
|
||
#ifndef BLOCK_COPY_H
|
||
#define BLOCK_COPY_H
|
||
|
||
#include "block/block.h"
|
||
|
||
typedef struct BlockCopyInFlightReq {
|
||
int64_t start_byte;
|
||
int64_t end_byte;
|
||
QLIST_ENTRY(BlockCopyInFlightReq) list;
|
||
CoQueue wait_queue; /* coroutines blocked on this request */
|
||
} BlockCopyInFlightReq;
|
||
|
||
typedef void (*ProgressBytesCallbackFunc)(int64_t bytes, void *opaque);
|
||
typedef void (*ProgressResetCallbackFunc)(void *opaque);
|
||
typedef struct BlockCopyState {
|
||
/*
|
||
* BdrvChild objects are not owned or managed by block-copy. They are
|
||
* provided by block-copy user and user is responsible for appropriate
|
||
* permissions on these children.
|
||
*/
|
||
BdrvChild *source;
|
||
BdrvChild *target;
|
||
BdrvDirtyBitmap *copy_bitmap;
|
||
int64_t cluster_size;
|
||
bool use_copy_range;
|
||
int64_t copy_range_size;
|
||
uint64_t len;
|
||
QLIST_HEAD(, BlockCopyInFlightReq) inflight_reqs;
|
||
|
||
BdrvRequestFlags write_flags;
|
||
|
||
/*
|
||
* skip_unallocated:
|
||
*
|
||
* Used by sync=top jobs, which first scan the source node for unallocated
|
||
* areas and clear them in the copy_bitmap. During this process, the bitmap
|
||
* is thus not fully initialized: It may still have bits set for areas that
|
||
* are unallocated and should actually not be copied.
|
||
*
|
||
* This is indicated by skip_unallocated.
|
||
*
|
||
* In this case, block_copy() will query the source’s allocation status,
|
||
* skip unallocated regions, clear them in the copy_bitmap, and invoke
|
||
* block_copy_reset_unallocated() every time it does.
|
||
*/
|
||
bool skip_unallocated;
|
||
|
||
/* progress_bytes_callback: called when some copying progress is done. */
|
||
ProgressBytesCallbackFunc progress_bytes_callback;
|
||
|
||
/*
|
||
* progress_reset_callback: called when some bytes reset from copy_bitmap
|
||
* (see @skip_unallocated above). The callee is assumed to recalculate how
|
||
* many bytes remain based on the dirty bit count of copy_bitmap.
|
||
*/
|
||
ProgressResetCallbackFunc progress_reset_callback;
|
||
void *progress_opaque;
|
||
} BlockCopyState;
|
||
|
||
BlockCopyState *block_copy_state_new(BdrvChild *source, BdrvChild *target,
|
||
int64_t cluster_size,
|
||
BdrvRequestFlags write_flags,
|
||
Error **errp);
|
||
|
||
void block_copy_set_callbacks(
|
||
BlockCopyState *s,
|
||
ProgressBytesCallbackFunc progress_bytes_callback,
|
||
ProgressResetCallbackFunc progress_reset_callback,
|
||
void *progress_opaque);
|
||
|
||
void block_copy_state_free(BlockCopyState *s);
|
||
|
||
int64_t block_copy_reset_unallocated(BlockCopyState *s,
|
||
int64_t offset, int64_t *count);
|
||
|
||
int coroutine_fn block_copy(BlockCopyState *s, int64_t start, uint64_t bytes,
|
||
bool *error_is_read);
|
||
|
||
#endif /* BLOCK_COPY_H */
|